Skip to content

Commit 0467475

Browse files
committed
Removed deprecated imports
1 parent 79dcb41 commit 0467475

7 files changed

Lines changed: 31 additions & 27 deletions

File tree

benchmarks/benchmark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from sklearn.decomposition import PCA
1010

1111
import tdamapper as tm
12-
from tdamapper.clustering import TrivialClustering
12+
from tdamapper.core import TrivialClustering
1313

1414

1515
def _segment(cardinality, dimension, noise=0.1, start=None, end=None):
@@ -81,7 +81,7 @@ def run_gm(X, n, p):
8181

8282
def run_tm(X, n, p):
8383
t0 = time.time()
84-
tm.core.MapperAlgorithm(
84+
tm.learn.MapperAlgorithm(
8585
cover=tm.cover.CubicalCover(
8686
n_intervals=n,
8787
overlap_frac=p,

src/tdamapper/clustering.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@ def fit(self, X, y=None):
4646
X, y = self._validate_X_y(X, y)
4747
cover = TrivialCover() if self.cover is None else self.cover
4848
cover = clone(cover)
49-
clustering = TrivialClustering() if self.clustering is None else self.clustering
49+
clustering = (
50+
tdamapper.core.TrivialClustering()
51+
if self.clustering is None
52+
else self.clustering
53+
)
5054
clustering = clone(clustering)
5155
n_jobs = self.n_jobs
5256
y = X if y is None else y

tests/example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@
2525

2626
# Visualize the Mapper graph
2727
fig = MapperPlot(graph, dim=2, seed=42, iterations=60).plot_plotly(colors=labels)
28-
fig.show(config={"scrollZoom": True})
28+
# fig.show(config={"scrollZoom": True})

tests/test_unit_core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@
44
import numpy as np
55
from sklearn.cluster import DBSCAN
66

7-
from tdamapper.clustering import TrivialClustering
87
from tdamapper.core import (
9-
MapperAlgorithm,
8+
TrivialClustering,
109
TrivialCover,
1110
mapper_connected_components,
1211
mapper_labels,
@@ -17,6 +16,7 @@
1716
ProximityCubicalCover,
1817
StandardCubicalCover,
1918
)
19+
from tdamapper.learn import MapperAlgorithm
2020

2121
dist = "euclidean"
2222

tests/test_unit_params.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
from sklearn.cluster import DBSCAN
44

55
from tdamapper._common import clone
6-
from tdamapper.clustering import MapperClustering
7-
from tdamapper.core import MapperAlgorithm
86
from tdamapper.cover import BallCover, CubicalCover
7+
from tdamapper.learn import MapperAlgorithm, MapperClustering
98

109

1110
class TestParams(unittest.TestCase):

tests/test_unit_plot.py

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
import networkx as nx
44
import numpy as np
55

6-
from tdamapper.clustering import TrivialClustering
7-
from tdamapper.core import MapperAlgorithm
6+
from tdamapper.core import TrivialClustering
87
from tdamapper.cover import BallCover
9-
from tdamapper.plot import MapperLayoutInteractive, MapperLayoutStatic, MapperPlot
8+
from tdamapper.learn import MapperAlgorithm
9+
from tdamapper.plot import MapperPlot
1010

1111

1212
class TestMapperPlot(unittest.TestCase):
@@ -72,46 +72,48 @@ def test_two_connected_clusters_deprecated(self):
7272
np.array([0.0, 0.0]),
7373
np.array([1.0, 1.0]),
7474
]
75-
mp = MapperAlgorithm(
75+
mapper_algo = MapperAlgorithm(
7676
cover=BallCover(1.1, metric="euclidean"), clustering=TrivialClustering()
7777
)
78-
g = mp.fit_transform(data, data)
79-
mp_plot1 = MapperLayoutInteractive(
78+
g = mapper_algo.fit_transform(data, data)
79+
mapper_plot_1 = MapperPlot(
8080
g,
8181
dim=2,
82-
colors=data,
8382
seed=123,
8483
iterations=10,
84+
)
85+
mapper_plot_1.plot_plotly(
86+
colors=data,
8587
agg=np.nanmax,
8688
width=200,
8789
height=200,
8890
title="example",
8991
cmap="jet",
9092
)
91-
mp_plot1.plot()
92-
mp_plot2 = MapperLayoutInteractive(
93+
mapper_plot_2 = MapperPlot(
9394
g,
9495
dim=3,
95-
colors=data,
9696
seed=123,
9797
iterations=10,
98+
)
99+
fig = mapper_plot_2.plot_plotly(
100+
colors=data,
98101
agg=np.nanmax,
99102
width=200,
100103
height=200,
101104
title="example",
102105
cmap="jet",
103106
)
104-
mp_plot2.plot()
105-
mp_plot2.update(
107+
mapper_plot_2.plot_plotly_update(
108+
fig,
106109
colors=data,
107-
seed=124,
108-
iterations=15,
109110
agg=np.nanmin,
110111
width=300,
111112
height=300,
112113
title="example-updated",
113114
cmap="viridis",
114115
)
115-
mp_plot2.plot()
116-
mp_plot3 = MapperLayoutStatic(g, colors=data, dim=2)
117-
mp_plot3.plot()
116+
mapper_plot_3 = MapperPlot(g, dim=2)
117+
mapper_plot_3.plot_matplotlib(
118+
colors=data,
119+
)

tests/test_unit_sklearn.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@
44
import numpy as np
55
from sklearn.utils.estimator_checks import check_estimator
66

7-
from tdamapper.clustering import MapperClustering
8-
from tdamapper.core import MapperAlgorithm
97
from tdamapper.cover import BallCover, CubicalCover, KNNCover
8+
from tdamapper.learn import MapperAlgorithm, MapperClustering
109
from tests.setup_logging import setup_logging
1110

1211

0 commit comments

Comments
 (0)