Merge pull request #293 from lucassabreu/chore/update-workflows

feat: update workflows versions

Author: lucassabreu

.github/workflows/golangci-lint.yml

@@ -4,7 +4,6 @@ on:
     tags:
       - v*
     branches:
-      - master
       - main
   pull_request:
 permissions:
@@ -16,12 +15,11 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
         with:
           go-version: 1.24
-          cache: false
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v7
+        uses: golangci/golangci-lint-action@v9
         with:
           version: latest

.github/workflows/release.yml

@@ -11,13 +11,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: go-setup
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24
       - name: install snapcraft
-        uses: samuelmeuli/action-snapcraft@v4
+        uses: samuelmeuli/action-snapcraft@v3
       - name: install nix
         uses: cachix/install-nix-action@v31
       - name: goreleaser-setup

.github/workflows/test-unit.yaml

@@ -2,15 +2,19 @@ name: Unit Tests
 on:
   pull_request:
   push:
+    tags:
+      - v*
+    branches:
+      - main
 jobs:
   tests:
     runs-on: ubuntu-latest
 
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
-      - uses: actions/setup-go@v5
+      - uses: actions/setup-go@v6
         with:
           go-version: 1.24
 
@@ -30,11 +34,11 @@ jobs:
         uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./coverage.txt
+          files: ./coverage.txt
           flags: unittests
 
       - name: Report test coverage to DeepSource
-        uses: deepsourcelabs/test-coverage-action@v1
+        uses: deepsourcelabs/test-coverage-action@master
         with:
           key: go
           coverage-file: ./coverage.txt

CHANGELOG.md

@@ -15,6 +15,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - updated github workflows to use the newest versions of the actions
 - removed unused code
+- fixed assorted lint errors
+
+### Thanks
+
+Thank you to [@reva](https://github.com/reva) for the improvements on
+[#292](https://github.com/lucassabreu/clockify-cli/pull/292).
 
 ## [v0.62.0] - 2026-03-20
 

Makefile

@@ -15,7 +15,7 @@ deps-upgrade: ## upgrade go dependencies
 	go get -u -v $(MAIN_PKG)
 	go mod tidy
 
-build: dist
+build: clean dist
 
 dist: deps-install dist/darwin dist/linux dist/windows ## build all cli versions (default)
 

api/httpClient.go

@@ -76,15 +76,19 @@ func (c *client) NewRequest(method, uri string, body interface{}) (*http.Request
 
 // Do executes a http.Request inside the Clockify's Client
 func (c *client) Do(
-	req *http.Request, v interface{}, name string) (*http.Response, error) {
+	req *http.Request, v interface{}, name string) (r *http.Response, err error) {
 
 	<-c.requestTickets
 
-	r, err := c.Client.Do(req)
+	r, err = c.Client.Do(req)
 	if err != nil {
 		return r, err
 	}
-	defer r.Body.Close()
+	defer func() {
+		if e := r.Body.Close(); e != nil {
+			err = e
+		}
+	}()
 
 	buf := new(bytes.Buffer)
 

cmd/clockify-cli/main.go

@@ -58,21 +58,21 @@ func execute() int {
 
 	stderr := cmd.ErrOrStderr()
 	if errors.Is(err, terminal.InterruptErr) {
-		fmt.Fprintln(stderr)
+		_, _ = fmt.Fprintln(stderr)
 		return exitCancel
 	}
 
 	var flagError *cmdutil.FlagError
 	if errors.As(err, &flagError) {
-		fmt.Fprintln(stderr, flagError.Error())
-		fmt.Fprintln(stderr, cmd.UsageString())
+		_, _ = fmt.Fprintln(stderr, flagError.Error())
+		_, _ = fmt.Fprintln(stderr, cmd.UsageString())
 		return exitError
 	}
 
 	if f.Config().IsDebuging() {
-		fmt.Fprintf(stderr, "%+v\n", err)
+		_, _ = fmt.Fprintf(stderr, "%+v\n", err)
 	} else {
-		fmt.Fprintln(stderr, err.Error())
+		_, _ = fmt.Fprintln(stderr, err.Error())
 	}
 
 	return exitError

internal/consoletest/test.go

@@ -89,7 +89,7 @@ func RunTestConsole(
 	if err != nil {
 		t.Fatalf("failed to create console: %v", err)
 	}
-	defer c.Close()
+	defer func() { _ = c.Close() }()
 
 	finished := false
 	t.Cleanup(func() {
@@ -109,7 +109,7 @@ func RunTestConsole(
 	}()
 
 	go func() {
-		defer c.Tty().Close()
+		defer func() { _ = c.Tty().Close() }()
 		if err = setup(c.Tty(), c.Tty()); err != nil {
 			t.Error(err)
 			return

pkg/cmd/client/add/add.go

@@ -8,7 +8,6 @@ import (
 	"github.com/lucassabreu/clockify-cli/api/dto"
 	"github.com/lucassabreu/clockify-cli/pkg/cmd/client/util"
 	"github.com/lucassabreu/clockify-cli/pkg/cmdutil"
-	"github.com/lucassabreu/clockify-cli/pkg/output/client"
 	"github.com/spf13/cobra"
 )
 
@@ -66,10 +65,6 @@ func NewCmdAdd(
 				return report(out, &of, cl)
 			}
 
-			if of.JSON {
-				client.ClientJSONPrint(cl, out)
-			}
-
 			return util.Report([]dto.Client{cl}, out, of)
 		},
 	}

pkg/cmd/version/version.go

@@ -12,11 +12,13 @@ func NewCmdVersion(f cmdutil.Factory) *cobra.Command {
 	return &cobra.Command{
 		Use:   "version",
 		Short: "Shows the CLI version",
-		Run: func(cmd *cobra.Command, _ []string) {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			v := f.Version()
-			fmt.Fprintln(cmd.OutOrStdout(),
+			_, err := fmt.Fprintln(cmd.OutOrStdout(),
 				"Version: "+v.Tag+", Commit: "+v.Commit+", Build At: "+v.Date,
 			)
+
+			return err
 		},
 	}
 }