fix: lint

Author: lucassabreu

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - updated github workflows to use the newest versions of the actions
 - removed unused code
+- fixed assorted lint errors
 
 ### Thanks
 

api/httpClient.go

@@ -76,15 +76,15 @@ func (c *client) NewRequest(method, uri string, body interface{}) (*http.Request
 
 // Do executes a http.Request inside the Clockify's Client
 func (c *client) Do(
-	req *http.Request, v interface{}, name string) (*http.Response, error) {
+	req *http.Request, v interface{}, name string) (r *http.Response, err error) {
 
 	<-c.requestTickets
 
-	r, err := c.Client.Do(req)
+	r, err = c.Client.Do(req)
 	if err != nil {
 		return r, err
 	}
-	defer r.Body.Close()
+	defer func() { err = r.Body.Close() }()
 
 	buf := new(bytes.Buffer)
 

cmd/clockify-cli/main.go

@@ -70,9 +70,9 @@ func execute() int {
 	}
 
 	if f.Config().IsDebuging() {
-		fmt.Fprintf(stderr, "%+v\n", err)
+		_, _ = fmt.Fprintf(stderr, "%+v\n", err)
 	} else {
-		fmt.Fprintln(stderr, err.Error())
+		_, _ = fmt.Fprintln(stderr, err.Error())
 	}
 
 	return exitError

internal/consoletest/test.go

@@ -89,7 +89,7 @@ func RunTestConsole(
 	if err != nil {
 		t.Fatalf("failed to create console: %v", err)
 	}
-	defer c.Close()
+	defer func() { _ = c.Close() }()
 
 	finished := false
 	t.Cleanup(func() {
@@ -109,7 +109,7 @@ func RunTestConsole(
 	}()
 
 	go func() {
-		defer c.Tty().Close()
+		defer func() { _ = c.Tty().Close() }()
 		if err = setup(c.Tty(), c.Tty()); err != nil {
 			t.Error(err)
 			return

pkg/cmd/client/add/add.go

@@ -8,7 +8,6 @@ import (
 	"github.com/lucassabreu/clockify-cli/api/dto"
 	"github.com/lucassabreu/clockify-cli/pkg/cmd/client/util"
 	"github.com/lucassabreu/clockify-cli/pkg/cmdutil"
-	"github.com/lucassabreu/clockify-cli/pkg/output/client"
 	"github.com/spf13/cobra"
 )
 
@@ -66,10 +65,6 @@ func NewCmdAdd(
 				return report(out, &of, cl)
 			}
 
-			if of.JSON {
-				client.ClientJSONPrint(cl, out)
-			}
-
 			return util.Report([]dto.Client{cl}, out, of)
 		},
 	}

pkg/output/task/quiet.go

@@ -10,7 +10,9 @@ import (
 // TaskPrintQuietly will only print the IDs
 func TaskPrintQuietly(ts []dto.Task, w io.Writer) error {
 	for i := 0; i < len(ts); i++ {
-		fmt.Fprintln(w, ts[i].ID)
+		if _, err := fmt.Fprintln(w, ts[i].ID); err != nil {
+			return err
+		}
 	}
 
 	return nil

pkg/output/user/quiet.go

@@ -10,7 +10,9 @@ import (
 // UserPrintQuietly will only print the IDs
 func UserPrintQuietly(users []dto.User, w io.Writer) error {
 	for i := 0; i < len(users); i++ {
-		fmt.Fprintln(w, users[i].ID)
+		if _, err := fmt.Fprintln(w, users[i].ID); err != nil {
+			return err
+		}
 	}
 
 	return nil

pkg/output/workspace/quiet.go

@@ -10,7 +10,9 @@ import (
 // WorkspacePrintQuietly will only print the IDs
 func WorkspacePrintQuietly(ws []dto.Workspace, w io.Writer) error {
 	for i := 0; i < len(ws); i++ {
-		fmt.Fprintln(w, ws[i].ID)
+		if _, err := fmt.Fprintln(w, ws[i].ID); err != nil {
+			return err
+		}
 	}
 
 	return nil