Skip to content

fix: redundant zsh auto-completion commands #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucassabreu merged 1 commit into from
May 21, 2026
+10 −17
Merged

fix: redundant zsh auto-completion commands #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- zsh auto-complete did not follow the right pattern for people the use auto-completion files

### Thanks

Thank you to [@HaleTom](https://github.com/HaleTom) for reporting the zsh problema at
[#295](https://github.com/lucassabreu/clockify-cli/issues/295).

## [v0.63.0] - 2026-03-26

### Added
Expand Down
18 changes: 1 addition & 17 deletions pkg/cmd/completion/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package completion

import (
"fmt"
"io"
"strings"

"github.com/MakeNowJust/heredoc"
Expand Down Expand Up @@ -36,7 +34,7 @@ func NewCmdCompletion() *cobra.Command {
case bash:
return cmd.Root().GenBashCompletion(out)
case zsh:
return genZshCompletion(cmd, out)
return cmd.Root().GenZshCompletion(out)
case fish:
return cmd.Root().GenFishCompletion(out, false)
case powershell:
Expand Down Expand Up @@ -85,17 +83,3 @@ func NewCmdCompletion() *cobra.Command {

return cmd
}

func genZshCompletion(cmd *cobra.Command, w io.Writer) error {
if _, err := fmt.Fprintln(w,
"autoload -U compinit; compinit"); err != nil {
return err
}

if err := cmd.Root().GenZshCompletion(w); err != nil {
return err
}

_, err := fmt.Fprintln(w, "compdef _clockify-cli clockify-cli")
return err
}
Loading