LDEV-5990: Function param hint and defaultValue missing from AST

Author: zspitzer

core/src/main/java/lucee/transformer/cfml/script/AbstrCFMLScriptTransformer.java

@@ -1039,7 +1039,24 @@ else if (idName.indexOf('.') != -1 || idName.indexOf('[') != -1) {
 				if (meta == null) meta = new HashMap<String, Attribute>();
 				for (int i = 0; i < _attrs.length; i++) {
 					_attr = _attrs[i];
-					meta.put(_attr.getName(), _attr);
+					String attrName = _attr.getName();
+					// Extract known argument attributes
+					if ("hint".equalsIgnoreCase(attrName)) {
+						hint = data.factory.toExprString(_attr.getValue());
+					}
+					else if ("displayname".equalsIgnoreCase(attrName)) {
+						displayName = data.factory.toExprString(_attr.getValue());
+					}
+					else if ("default".equalsIgnoreCase(attrName) && defVal == null) {
+						defVal = _attr.getValue();
+					}
+					else if ("passbyreference".equalsIgnoreCase(attrName) || "passby".equalsIgnoreCase(attrName)) {
+						ExprBoolean eb = data.factory.toExprBoolean(_attr.getValue());
+						if (eb instanceof LitBoolean) passByRef = (LitBoolean) eb;
+					}
+					else {
+						meta.put(attrName, _attr);
+					}
 				}
 			}
 

test/tickets/LDEV5990.cfc

@@ -0,0 +1,89 @@
+component extends="org.lucee.cfml.test.LuceeTestCase" labels="ast" {
+
+	variables.testDir = getDirectoryFromPath( getCurrentTemplatePath() ) & "LDEV5990/";
+
+	function run( testResults, testBox ) {
+
+		describe( "LDEV-5990: Function param hint and defaultValue missing from AST", function() {
+
+			it( "should include hint value on function parameters", function() {
+				// Use astFromPath for CFC files
+				var ast = astFromPath( variables.testDir & "hintedParams.cfc" );
+
+				// Find the withHint function
+				var func = findFunction( ast, "withHint" );
+				expect( func ).notToBeNull( "withHint function should be found in AST" );
+
+				// Check the first param has hint with correct value
+				var param = func.params[ 1 ];
+				expect( param.name.value ).toBe( "name" );
+				expect( param.hint ).notToBeNull( "param should have hint attribute" );
+				// Bug: hint.value is empty string instead of the actual hint text
+				expect( param.hint.value ).toBe( "The user's full name", "hint value should contain the original hint text" );
+			});
+
+			it( "should include defaultValue on function parameters", function() {
+				var ast = astFromPath( variables.testDir & "hintedParams.cfc" );
+
+				// Find the withDefault function
+				var func = findFunction( ast, "withDefault" );
+				expect( func ).notToBeNull( "withDefault function should be found in AST" );
+
+				// Check the first param has defaultValue
+				var param = func.params[ 1 ];
+				expect( param.name.value ).toBe( "greeting" );
+				// Bug: defaultValue key is completely missing from param
+				expect( structKeyExists( param, "defaultValue" ) ).toBeTrue( "param should have defaultValue key" );
+				expect( param.defaultValue.value ).toBe( "Hello", "defaultValue should contain the default value" );
+			});
+
+			it( "should include both hint and defaultValue on same parameter", function() {
+				var ast = astFromPath( variables.testDir & "hintedParams.cfc" );
+
+				// Find the withBoth function
+				var func = findFunction( ast, "withBoth" );
+				expect( func ).notToBeNull( "withBoth function should be found in AST" );
+
+				// Check the first param has both hint and defaultValue
+				var param = func.params[ 1 ];
+				expect( param.name.value ).toBe( "message" );
+				// Bug: hint.value is empty, defaultValue key is missing
+				expect( param.hint.value ).toBe( "The message to display", "hint value should be preserved" );
+				expect( structKeyExists( param, "defaultValue" ) ).toBeTrue( "param should have defaultValue key" );
+				expect( param.defaultValue.value ).toBe( "Welcome", "defaultValue should be preserved" );
+			});
+
+		});
+
+	}
+
+	/**
+	 * Recursively find a FunctionDeclaration by name
+	 */
+	private function findFunction( required struct node, required string name ) {
+		var nodeType = node.type ?: "";
+		if ( isSimpleValue( nodeType ) && nodeType == "FunctionDeclaration" ) {
+			var nodeName = node.name ?: "";
+			if ( isStruct( nodeName ) ) nodeName = nodeName.value ?: "";
+			if ( isSimpleValue( nodeName ) && uCase( nodeName ) == uCase( name ) ) {
+				return node;
+			}
+		}
+		for ( var key in node ) {
+			var val = node[ key ];
+			if ( isStruct( val ) ) {
+				var result = findFunction( val, name );
+				if ( !isNull( result ) ) return result;
+			} else if ( isArray( val ) ) {
+				for ( var item in val ) {
+					if ( isStruct( item ) ) {
+						var result = findFunction( item, name );
+						if ( !isNull( result ) ) return result;
+					}
+				}
+			}
+		}
+		return;
+	}
+
+}

test/tickets/LDEV5990/hintedParams.cfc

@@ -0,0 +1,21 @@
+component {
+
+	function withHint(
+		required string name hint="The user's full name"
+	) {
+		return name;
+	}
+
+	function withDefault(
+		string greeting default="Hello"
+	) {
+		return greeting;
+	}
+
+	function withBoth(
+		required string message hint="The message to display" default="Welcome"
+	) {
+		return message;
+	}
+
+}