Skip to content

LDEV-6115 enable virtual threads for java 25+ #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zspitzer wants to merge 1 commit into
base: 7.1
Choose a base branch
from
+6 −5
Open

LDEV-6115 enable virtual threads for java 25+ #2760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/main/java/lucee/runtime/thread/ThreadUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@

public final class ThreadUtil {

private static final boolean ALLOW_FUTURE_THREADS = false;
// virtual threads are safe from Java 25+ (JEP 491: synchronized no longer pins virtual threads)
private static final boolean ALLOW_VIRTUAL_THREADS = SystemUtil.JAVA_VERSION >= SystemUtil.JAVA_VERSION_25;
// private static final Class<?> THREAD_CLASS = Thread.class;
private static final Class<?> RUNNABLE_CLASS = Runnable.class;
private static Class<?> threadBuilderClass;
Expand Down Expand Up @@ -220,7 +221,7 @@ public static boolean isInNativeMethod(Thread thread, boolean defaultValue) {
}

public static Thread getThread(Runnable task) {
return getThread(task, ALLOW_FUTURE_THREADS);
return getThread(task, ALLOW_VIRTUAL_THREADS);

}

Expand All @@ -243,7 +244,7 @@ public static Thread getThread(Runnable task, boolean allowVirtual) {
}

public static ExecutorService createExecutorService(int maxThreads) {
return createExecutorService(maxThreads, ALLOW_FUTURE_THREADS);
return createExecutorService(maxThreads, ALLOW_VIRTUAL_THREADS);
}

public static ExecutorService createExecutorService(int maxThreads, boolean allowVirtual) {
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/lucee/runtime/util/threading/StatmentClose.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import lucee.runtime.db.DatasourceConnection;
import lucee.runtime.db.DatasourceManagerImpl;
import lucee.runtime.exp.PageException;
import lucee.runtime.thread.ThreadUtil;

public final class StatmentClose implements CloserJob {

Expand All @@ -29,8 +30,7 @@ public String getLablel() {

@Override
public void execute() throws PageException {
// TODO add virtual threads
new Thread(() -> {
ThreadUtil.getThread(() -> {
try {
DBUtil.closeEL(stat);
manager.releaseConnection(null, dc);
Expand Down