LDEV-6211 improve metadata exception logging, but lower to DEBUG

Author: zspitzer

source/java/src/org/lucee/extension/image/Metadata.java

@@ -90,20 +90,20 @@ public static void addExifInfoToStruct(final Resource res, Struct info, Log log)
 						}
 					}
 					catch (Exception e) {
-						if (log != null) log.log(Log.LEVEL_WARN, "imaging", "failed to read EXIF metadata from [" + res + "], metadata is ignored", e);
+						if (log != null) log.log(Log.LEVEL_DEBUG, "imaging", "failed to read EXIF metadata from [" + res + "], metadata is ignored", e);
 					}
 				}
 				// GPS
 				try {
 					gps(jpegMetadata, info);
 				}
 				catch (Exception e) {
-					if (log != null) log.error("imaging", e);
+					if (log != null) log.log(Log.LEVEL_DEBUG, "imaging", "failed to read GPS metadata from [" + res + "], metadata is ignored", e);
 				}
 			}
 		}
 		catch (Exception ex) {
-			if (log != null) log.error("imaging", ex);
+			if (log != null) log.log(Log.LEVEL_DEBUG, "imaging", "failed to read EXIF metadata from [" + res + "], metadata is ignored", ex);
 		}
 		finally {
 			Util.closeEL(is);

tests/LDEV6211.cfc

@@ -0,0 +1,33 @@
+component extends="org.lucee.cfml.test.LuceeTestCase" labels="image" {
+
+	variables.imgDir = getDirectoryFromPath( getCurrentTemplatePath() ) & "images/";
+	variables.testDir = getTempDirectory() & "ldev6211/";
+
+	function beforeAll(){
+		if ( directoryExists( testDir ) ) directoryDelete( testDir, true );
+		directoryCreate( testDir );
+
+		fileCopy( imgDir & "small-sample.webp", testDir & "sample.webp" );
+		// file with a truly unknown extension to force the outer catch
+		fileCopy( imgDir & "small-sample.webp", testDir & "mystery.xyz" );
+	}
+
+	function run( testResults, testBox ){
+		describe( "LDEV-6211 unsupported formats must not throw from imageInfo", function(){
+
+			it( title="imageInfo on a .webp file returns without throwing", body=function(){
+				var info = imageInfo( testDir & "sample.webp" );
+				expect( info.width ).toBeGT( 0 );
+				expect( info.height ).toBeGT( 0 );
+			});
+
+			it( title="imageInfo on a file with unknown extension returns without throwing", body=function(){
+				var info = imageInfo( testDir & "mystery.xyz" );
+				expect( info.width ).toBeGT( 0 );
+				expect( info.height ).toBeGT( 0 );
+			});
+
+		});
+	}
+
+}