Skip to content

Commit fb79093

Browse files
committed
add support for javax
1 parent 151c286 commit fb79093

10 files changed

Lines changed: 627 additions & 15 deletions

File tree

.github/workflows/main.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,7 @@ jobs:
1616
with:
1717
distribution: 'temurin'
1818
java-version: '11'
19-
- name: Cache Maven packages
20-
uses: actions/cache@v3
21-
with:
22-
path: ~/.m2
23-
key: lucee-script-runner-maven-cache
19+
2420
- name: Cache Maven packages
2521
uses: actions/cache@v4
2622
with:
@@ -33,7 +29,7 @@ jobs:
3329
id: extract-version
3430
run: |
3531
VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
36-
echo "::set-output name=VERSION::$VERSION"
32+
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
3733
3834
- name: Cache Lucee files
3935
uses: actions/cache@v4
@@ -53,10 +49,11 @@ jobs:
5349
env:
5450
testLabels: image
5551
testAdditional: ${{ github.workspace }}/tests
56-
LUCEE_TEST_VERSIONS: '[ {"version": " 7.0.0.242-RC", "query": "7.0/all/light"}]'
52+
LUCEE_TEST_VERSIONS_JAKARTA: ${{ vars.LUCEE_TEST_VERSIONS_JAKARTA }}
5753
strategy:
54+
fail-fast: false
5855
matrix:
59-
lucee: [ {"version": " 7.0.0.242-RC", "query": "7.0/all/light"}]
56+
lucee: ${{ fromJSON(vars.LUCEE_TEST_VERSIONS_JAKARTA) }}
6057
java: [ 11, 21 ]
6158
services:
6259
minio:
@@ -94,7 +91,7 @@ jobs:
9491
with:
9592
java-version: ${{ matrix.java }}
9693
distribution: 'adopt'
97-
94+
9895
- name: Run Lucee Test Suite
9996
uses: lucee/script-runner@main
10097
with:
@@ -111,7 +108,7 @@ jobs:
111108

112109
deploy:
113110
runs-on: ubuntu-latest
114-
needs: [build-and-test]
111+
needs: [setup, build-and-test]
115112
if: always() && needs.build-and-test.result == 'success'
116113
steps:
117114
- name: Checkout repository
@@ -149,4 +146,4 @@ jobs:
149146
else
150147
echo "------- Maven Deploy release on ${{ github.event_name }} -------";
151148
mvn -B -e -f pom.xml clean deploy -DperformRelease=true --settings maven-settings.xml
152-
fi
149+
fi

build.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ destdir="${build}" debug="true" debuglevel="lines,vars,source">
112112
<copy todir="${dist}/extension/jars">
113113
<fileset dir="${lib}">
114114
<include name="**/*.jar"/>
115+
<exclude name="**/javax.*"/>
115116
<exclude name="**/javax.servlet-api-*"/>
116117
<exclude name="**/javax.el-api-*"/>
117118
<exclude name="**/jakarta*"/>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<modelVersion>4.0.0</modelVersion>
55
<groupId>org.lucee</groupId>
66
<artifactId>image-extension</artifactId>
7-
<version>3.0.0.9</version>
7+
<version>3.0.1.0-SNAPSHOT</version>
88
<packaging>pom</packaging>
99
<name>Image Extension</name>
1010

source/java/.classpath

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,6 @@
3434
<classpathentry kind="lib" path="libs/org.lucee.xmpcore-6.1.11.jar"/>
3535
<classpathentry kind="lib" path="libs/org.lucee.gotson-webp-0.2.2.jar"/>
3636
<classpathentry kind="lib" path="libs/jakarta.jakartaee-api-10.0.0.jar"/>
37+
<classpathentry kind="lib" path="libs/javax.servlet.jar"/>
3738
<classpathentry kind="output" path="bin"/>
3839
</classpath>

source/java/libs/javax.servlet.jar

150 KB
Binary file not shown.

source/java/src/org/lucee/extension/image/tag/Image.java renamed to source/java/src/org/lucee/extension/image/tag/jakarta/Image.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.lucee.extension.image.tag;
1+
package org.lucee.extension.image.tag.jakarta;
22

33
import java.awt.Color;
44
import java.io.IOException;

source/java/src/org/lucee/extension/image/tag/TagImpl.java renamed to source/java/src/org/lucee/extension/image/tag/jakarta/TagImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.lucee.extension.image.tag;
1+
package org.lucee.extension.image.tag.jakarta;
22

33
import jakarta.servlet.jsp.tagext.Tag;
44
import lucee.loader.engine.CFMLEngine;

0 commit comments

Comments
 (0)