LDEV-6243, LDEV-6244, LDEV-6245: fix race condition, perf improvements#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three tickets, 9 commits. Bug fix + performance improvements found via JFR profiling.
LDEV-6243 — member function race condition
CommonUtil.getMembers()publish-before-populate race causes intermittentCan't cast Object type [Struct] to a value of type [image]on member function calls under concurrency (~1% failure rate).Fix: Double-checked locking with volatile, build into local before publish.
LDEV-6244 — replace GetApplicationSettings BIF
getCoders()calledGetApplicationSettingsBIF via reflection on every image operation, triggering 128kDummyWSHandlerexceptions per benchmark run.Fix: Use
pc.getApplicationContext().getCustom("image")directly, same pattern as extension-s3. Also fixes the missingo =assignment for the "coders" fallback key.LDEV-6245 — performance (5 fixes)
_coderstatic cache (if (true ||bypass)returninAImageIOInterface.write()— was writing files twicegetFormatbyMimeTypeFormatExtractoverloadBenchmark results (5k ops, inspect never)
Exceptions: 354,332 → 2,309 (-99.3%)
Test plan