Add unit tests + cross-repo integration CI job#4
Merged
Conversation
…t invoking listener in that path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebSocketClientTest.cfcfrom a single smoke test into a BDD-style suite (6 tests) covering: BIF loader/OSGi health, non-component listener rejection,wss://scheme handling,http://scheme rejection, connection-refused timing, 5s hardcoded connection-timeout enforcement.tests/README.mdexplaining the unit/integration split and the cross-repo setup.workflow_dispatchonly (no more push-to-master auto-deploy).test-integrationjob sparse-checkoutstests/integration/from the server repo, runs the full server-side integration suite against this branch's freshly-built client.lex+ the latest published server.lex. Matrix is a minimal 6.2/stable + 7.0/stable × Java per Lucee version — the server repo owns the broader matrix.Test plan
test-integrationpasses on 6.2/stable/jar and 7.0/stable/jarworkflow_dispatchWhat's deliberately not tested here
onError( type="connect", ... )listener callback on sync TCP-connect failure: nv-websocket-client throwsWebSocketExceptiondirectly from blockingconnect()without invoking the adapter'sonConnectErrorin that path. TheonErroradapter hook only fires for async/mid-session failure modes, which aren't cheaply triggerable in unit tests.extension-websocket'stests/integration/and run here via the new cross-repo job.