Skip to content

Add unit tests + cross-repo integration CI job#4

Merged
zspitzer merged 6 commits intomasterfrom
test/behavioural-coverage
Apr 17, 2026
Merged

Add unit tests + cross-repo integration CI job#4
zspitzer merged 6 commits intomasterfrom
test/behavioural-coverage

Conversation

@zspitzer
Copy link
Copy Markdown
Member

Summary

  • Expand WebSocketClientTest.cfc from a single smoke test into a BDD-style suite (6 tests) covering: BIF loader/OSGi health, non-component listener rejection, wss:// scheme handling, http:// scheme rejection, connection-refused timing, 5s hardcoded connection-timeout enforcement.
  • Add tests/README.md explaining the unit/integration split and the cross-repo setup.
  • Workflow changes:
    • Deploy now gated on workflow_dispatch only (no more push-to-master auto-deploy).
    • New test-integration job sparse-checkouts tests/integration/ from the server repo, runs the full server-side integration suite against this branch's freshly-built client .lex + the latest published server .lex. Matrix is a minimal 6.2/stable + 7.0/stable × Java per Lucee version — the server repo owns the broader matrix.

Test plan

  • Unit tests pass on 6.2 stable + snapshot × Java 11 + 21, and 7.0 stable + snapshot × Java 11 + 21 (8 combos)
  • test-integration passes on 6.2/stable/jar and 7.0/stable/jar
  • Deploy does not trigger on push, only on workflow_dispatch
  • Full behavioural coverage via cross-repo integration (no duplication)

What's deliberately not tested here

  • onError( type="connect", ... ) listener callback on sync TCP-connect failure: nv-websocket-client throws WebSocketException directly from blocking connect() without invoking the adapter's onConnectError in that path. The onError adapter hook only fires for async/mid-session failure modes, which aren't cheaply triggerable in unit tests.
  • Round-trip send/receive / lifecycle / binary / disconnect — those live in extension-websocket's tests/integration/ and run here via the new cross-repo job.

@zspitzer zspitzer merged commit 0507d0c into master Apr 17, 2026
27 checks passed
@zspitzer zspitzer deleted the test/behavioural-coverage branch April 17, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant