use cfadmin restart instead of updateRHExtension to trigger reflection fallback

Author: zspitzer

.github/workflows/main.yml

@@ -486,11 +486,37 @@ jobs:
             echo "CONFIG_OVERRIDE_FAILED=true" >> $GITHUB_OUTPUT
           fi
 
-      - name: Run reflection hot-reinstall test
+      - name: Trigger Lucee engine restart (LDEV-6221 scenario)
+        id: restart-trigger
+        continue-on-error: true
+        run: |
+          # Calls cfadmin action="restart" — reloads the CFMLEngine while Tomcat
+          # stays up. Forces the fresh extension to hit its reflection fallback
+          # because Tomcat's endpoint registry still has the pre-restart class.
+          RESPONSE=$(curl -s -w "\n%{http_code}" http://localhost:8888/tests/integration/trigger-lucee-restart.cfm)
+          HTTP_CODE=$(echo "$RESPONSE" | tail -1)
+          BODY=$(echo "$RESPONSE" | sed '$d')
+          echo "$BODY"
+          if [ "$HTTP_CODE" != "200" ] || echo "$BODY" | grep -q "FAILED"; then
+            echo "RESTART_TRIGGER_FAILED=true" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Wait for Lucee to come back online
+        run: |
+          # Engine restart takes a few seconds — poll a trivial endpoint until 200
+          for i in {1..60}; do
+            if curl -s -o /dev/null -w "%{http_code}" http://localhost:8888/tests/test-websocket-info.cfm | grep -q "200"; then
+              echo "Lucee responding after $i attempts"
+              break
+            fi
+            sleep 1
+          done
+
+      - name: Run post-restart reflection round-trip
         id: reflection-test
         continue-on-error: true
         run: |
-          RESPONSE=$(curl -s -w "\n%{http_code}" http://localhost:8888/tests/integration/test-reflection-reinstall.cfm)
+          RESPONSE=$(curl -s -w "\n%{http_code}" http://localhost:8888/tests/integration/test-reflection-restart.cfm)
           HTTP_CODE=$(echo "$RESPONSE" | tail -1)
           BODY=$(echo "$RESPONSE" | sed '$d')
           echo "$BODY"

tests/integration/test-reflection-reinstall.cfm

@@ -0,0 +1,51 @@
+<cfscript>
+// Post-restart round-trip. Assumes Lucee has already been restarted via
+// trigger-lucee-restart.cfm — the CI job orders these correctly and polls
+// for the engine to come back before calling this.
+//
+// Proves the websocket extension's reflection fallback works: Tomcat's endpoint
+// registry still points at the pre-restart class, but the fresh extension injected
+// itself into the static slot via reflection. A successful round-trip confirms the
+// path works; the CI job separately greps catalina.out for the reflection warning
+// to prove the path was actually exercised.
+
+writeOutput( "=== Post-Restart Reflection Round-Trip ===" & chr( 10 ) );
+
+try {
+	if ( !structKeyExists( getFunctionList(), "CreateWebSocketClient" ) )
+		throw( message="CreateWebSocketClient not available", type="TestSetupError" );
+
+	wsUrl    = "ws://localhost:8888/ws/TestListener";
+	listener = new tests.integration.ClientListener();
+	ws       = CreateWebSocketClient( wsUrl, listener );
+	sleep( 500 );
+
+	ws.sendText( "reflectionCheck" );
+	sleep( 500 );
+
+	ws.disconnect();
+	sleep( 500 );
+
+	received = listener.getMessages();
+	writeOutput( "Received: " & received.toJSON() & chr( 10 ) );
+
+	errors = [];
+	if ( !received.find( "ECHO:reflectionCheck" ) )
+		arrayAppend( errors, "expected ECHO:reflectionCheck post-restart; got: " & received.toJSON() );
+
+	if ( arrayLen( errors ) ) {
+		writeOutput( chr( 10 ) & "FAILED:" & chr( 10 ) );
+		for ( err in errors )
+			writeOutput( "  - #err#" & chr( 10 ) );
+		cfheader( statuscode=500, statustext="Test Failed" );
+	}
+	else {
+		writeOutput( chr( 10 ) & "SUCCESS: round-trip works post-restart — CI will confirm the reflection warning in catalina.out" & chr( 10 ) );
+	}
+}
+catch ( any e ) {
+	writeOutput( "FAILED with exception:" & chr( 10 ) );
+	writeOutput( e.stacktrace );
+	cfheader( statuscode=500, statustext="Test Failed" );
+}
+</cfscript>

tests/integration/test-reflection-restart.cfm

@@ -0,0 +1,31 @@
+<cfscript>
+// Triggers a Lucee engine restart via the server admin API.
+// Tomcat stays up — only the CFMLEngine reloads. This is the LDEV-6221 scenario:
+// when the fresh engine's extension classes try to register their endpoint, Tomcat
+// already has the endpoint class from before the restart, so the extension falls
+// back to inject() via reflection.
+//
+// The CI job curls this, then waits for Lucee to come back, then runs
+// test-reflection-restart.cfm which proves round-trip still works.
+
+writeOutput( "=== Triggering Lucee engine restart ===" & chr( 10 ) );
+
+try {
+	adminPassword = server.system.environment.LUCEE_ADMIN_PASSWORD ?: "";
+	if ( adminPassword == "" )
+		throw( message="LUCEE_ADMIN_PASSWORD env var not set", type="TestSetupError" );
+
+	cfadmin(
+		action   = "restart",
+		type     = "server",
+		password = adminPassword
+	);
+
+	writeOutput( "Restart call returned — engine is reloading" & chr( 10 ) );
+}
+catch ( any e ) {
+	writeOutput( "FAILED to trigger restart: " & e.message & chr( 10 ) );
+	writeOutput( e.stacktrace );
+	cfheader( statuscode=500, statustext="Restart Trigger Failed" );
+}
+</cfscript>