Drop onLastClose final-event assertion (flaky)#18
Closed
Conversation
…c ASM bytecode load on stale bundle classloader
…bypass ClazzDynamic bytecode load
… with final onClose
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle test asserted onLastClose must be the last event, but onLastClose runs on an async thread (AsyncInvoker in BaseWebSocketEndpoint) and can race with the final onClose. Observed failure: master CI run 24590755938 on 7.0/stable/jar showed events ending in
onLastClose, onCloseinstead of the asserted…, onLastClose.Presence + count of each event is still asserted — this only drops the relative-ordering check that was racy.