fix: resolve $ref pointers in operation parameters#27
Merged
Conversation
OpenAPI 3.x specs commonly declare parameters once in components.parameters and reference them via \$ref from operations (Stripe, Slack, GitHub, Sympla, etc all do this). The extractor was only resolving \$ref for schemas, treating ref-only parameter entries as raw objects with undefined name/in fields. This produced 'Cannot add option --undefined <undefined>' crashes. Added resolveParameter() in a new refs.ts module and a guard against parameters missing name/in after resolution. As part of the change, split extractor.ts into focused modules (refs, params, naming) to keep each file under 150 lines. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Specs that declare parameters once in `components.parameters` and reference them via `$ref` from operations (Stripe, Slack, GitHub, Sympla, etc.) crash spec2cli with:
```
Error: Cannot add option '--undefined ' to command 'X' due to conflicting flag '--undefined'
```
The extractor was resolving `$ref` for schemas only — parameter `$ref` entries were treated as raw objects, leaving `name` and `in` undefined.
Fix
Test plan
🤖 Generated with Claude Code