hide concealed foci from cameras/other minor tweaks#847
Open
scoutyoshimoto wants to merge 5 commits intoluciensadi:masterfrom
Open
hide concealed foci from cameras/other minor tweaks#847scoutyoshimoto wants to merge 5 commits intoluciensadi:masterfrom
scoutyoshimoto wants to merge 5 commits intoluciensadi:masterfrom
Conversation
scoutyoshimoto
changed the title
luciensadi
reviewed
Apr 4, 2026
luciensadi
reviewed
Apr 30, 2026
| } | ||
|
|
||
| // Conceealed foci should not show in photos | ||
| if (GET_OBJ_TYPE(found_eq) == ITEM_FOCUS && IS_OBJ_STAT(found_eq, ITEM_EXTRA_CONCEALED_IN_EQ)) { |
Owner
There was a problem hiding this comment.
Does this compile? I'm still having a hard time finding a found_eq ref in the preceding code. It looks like it needs to be GET_EQ(found_ch, j) instead of found_eq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as if there invisible to everyone except staff no matter what, a nikon shouldn't see them either
reword the text in COUNT to clarify that mails are fine now