Skip to content

Commit d2a98a3

Browse files
jwoertinkjwoertink
committed
reenable all specs but keep the browser and windows specs out for now until we can find a way to handle the yarn stuff better
1 parent 2d9365c commit d2a98a3

1 file changed

Lines changed: 110 additions & 127 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 110 additions & 127 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ jobs:
3232
fail-fast: false
3333
matrix:
3434
include:
35+
- { os: ubuntu-latest }
3536
- { os: macos-latest }
3637
- { os: windows-latest }
37-
- { os: ubuntu-latest }
3838
runs-on: ${{matrix.os}}
3939
continue-on-error: false
4040
steps:
@@ -54,9 +54,9 @@ jobs:
5454
fail-fast: false
5555
matrix:
5656
include:
57-
# - { os: macos-latest }
58-
- { os: windows-latest }
5957
- { os: ubuntu-latest }
58+
- { os: macos-latest }
59+
# - { os: windows-latest }
6060
runs-on: ${{matrix.os}}
6161
continue-on-error: false
6262
steps:
@@ -85,134 +85,117 @@ jobs:
8585
run: crystal build src/lucky.cr
8686
- name: Add current directory to PATH
8787
run: echo "$PWD" >> "$GITHUB_PATH"
88-
89-
# NOTE: Using `env: SHARDS_OVERRIDE` here doesn't seem to work. It will throw a missing file error on every OS
90-
# - name: Run e2e Browser app with authentication flow
91-
# if: matrix.os == 'windows-latest'
92-
# run: |
93-
# $env:SHARDS_OVERRIDE = Join-Path -Path $pwd.Path -ChildPath "shard.override.yml"
94-
# crystal spec spec/end_to_end/browser_with_auth_spec.cr
9588
- name: Set SHARDS_OVERRIDE
9689
run: echo "SHARDS_OVERRIDE=${GITHUB_WORKSPACE}/shard.override.yml" >> "$GITHUB_ENV"
9790
- name: Run e2e Browser app with authentication flow
9891
run: crystal spec spec/end_to_end/browser_with_auth_spec.cr
9992

100-
# browser_without_auth:
101-
# needs: [check_format, platform_specs]
102-
# strategy:
103-
# fail-fast: false
104-
# matrix:
105-
# include:
106-
# - { os: macos-latest }
107-
# - { os: windows-latest }
108-
# - { os: ubuntu-latest }
109-
# runs-on: ${{matrix.os}}
110-
# continue-on-error: false
111-
# steps:
112-
# - uses: actions/checkout@v6
113-
# - name: Setup PostgreSQL
114-
# uses: ikalnytskyi/action-setup-postgres@v8
115-
# with:
116-
# username: postgres
117-
# password: postgres
118-
# port: 5432
119-
# postgres-version: 18
120-
# - uses: actions/setup-node@v6
121-
# with:
122-
# node-version: 24
123-
# - uses: crystal-lang/install-crystal@v1
124-
# with:
125-
# crystal: latest
126-
# - name: Install shards
127-
# run: shards install --skip-postinstall --skip-executables
128-
# - name: Install LuckyCLI
129-
# run: crystal build src/lucky.cr
130-
# - name: Add current directory to PATH
131-
# shell: bash
132-
# run: echo "$PWD" >> "$GITHUB_PATH"
133-
# - name: Run e2e Browser app without authentication flow
134-
# if: matrix.os == 'windows-latest'
135-
# run: |
136-
# $env:SHARDS_OVERRIDE = Join-Path -Path $pwd.Path -ChildPath "shard.override.yml"
137-
# crystal spec spec/end_to_end/browser_no_auth_spec.cr
138-
# - name: Run e2e Browser app without authentication flow
139-
# if: matrix.os != 'windows-latest'
140-
# run: SHARDS_OVERRIDE="$(pwd)/shard.override.yml" crystal spec spec/end_to_end/browser_no_auth_spec.cr
93+
browser_without_auth:
94+
needs: [check_format, platform_specs]
95+
strategy:
96+
fail-fast: false
97+
matrix:
98+
include:
99+
- { os: ubuntu-latest }
100+
- { os: macos-latest }
101+
# - { os: windows-latest }
102+
runs-on: ${{matrix.os}}
103+
continue-on-error: false
104+
steps:
105+
- uses: actions/checkout@v6
106+
- name: Setup PostgreSQL
107+
uses: ikalnytskyi/action-setup-postgres@v8
108+
with:
109+
username: postgres
110+
password: postgres
111+
port: 5432
112+
postgres-version: 18
113+
- uses: actions/setup-node@v6
114+
with:
115+
node-version: 24
116+
- name: Enable Corepack (for yarn)
117+
run: |
118+
corepack enable
119+
corepack prepare yarn@1.22.22 --activate
120+
yarn --version
121+
- uses: crystal-lang/install-crystal@v1
122+
with:
123+
crystal: latest
124+
- name: Install shards
125+
run: shards install --skip-postinstall --skip-executables
126+
- name: Install LuckyCLI
127+
run: crystal build src/lucky.cr
128+
- name: Add current directory to PATH
129+
run: echo "$PWD" >> "$GITHUB_PATH"
130+
- name: Set SHARDS_OVERRIDE
131+
run: echo "SHARDS_OVERRIDE=${GITHUB_WORKSPACE}/shard.override.yml" >> "$GITHUB_ENV"
132+
- name: Run e2e Browser app without authentication flow
133+
run: crystal spec spec/end_to_end/browser_no_auth_spec.cr
141134

142-
# api_with_auth:
143-
# needs: [check_format, platform_specs]
144-
# strategy:
145-
# fail-fast: false
146-
# matrix:
147-
# include:
148-
# - { os: macos-latest }
149-
# - { os: windows-latest }
150-
# - { os: ubuntu-latest }
151-
# runs-on: ${{matrix.os}}
152-
# continue-on-error: false
153-
# steps:
154-
# - uses: actions/checkout@v6
155-
# - name: Setup PostgreSQL
156-
# uses: ikalnytskyi/action-setup-postgres@v8
157-
# with:
158-
# username: postgres
159-
# password: postgres
160-
# port: 5432
161-
# postgres-version: 18
162-
# - uses: crystal-lang/install-crystal@v1
163-
# with:
164-
# crystal: latest
165-
# - name: Install shards
166-
# run: shards install --skip-postinstall --skip-executables
167-
# - name: Install LuckyCLI
168-
# run: crystal build src/lucky.cr
169-
# - name: Add current directory to PATH
170-
# shell: bash
171-
# run: echo "$PWD" >> "$GITHUB_PATH"
172-
# - name: Run e2e API app with authentication flow
173-
# if: matrix.os == 'windows-latest'
174-
# run: |
175-
# $env:SHARDS_OVERRIDE = Join-Path -Path $pwd.Path -ChildPath "shard.override.yml"
176-
# crystal spec spec/end_to_end/api_with_auth_spec.cr
177-
# - name: Run e2e API app with authentication flow
178-
# if: matrix.os != 'windows-latest'
179-
# run: SHARDS_OVERRIDE="$(pwd)/shard.override.yml" crystal spec spec/end_to_end/api_with_auth_spec.cr
135+
api_with_auth:
136+
needs: [check_format, platform_specs]
137+
strategy:
138+
fail-fast: false
139+
matrix:
140+
include:
141+
- { os: ubuntu-latest }
142+
- { os: macos-latest }
143+
- { os: windows-latest }
144+
runs-on: ${{matrix.os}}
145+
continue-on-error: false
146+
steps:
147+
- uses: actions/checkout@v6
148+
- name: Setup PostgreSQL
149+
uses: ikalnytskyi/action-setup-postgres@v8
150+
with:
151+
username: postgres
152+
password: postgres
153+
port: 5432
154+
postgres-version: 18
155+
- uses: crystal-lang/install-crystal@v1
156+
with:
157+
crystal: latest
158+
- name: Install shards
159+
run: shards install --skip-postinstall --skip-executables
160+
- name: Install LuckyCLI
161+
run: crystal build src/lucky.cr
162+
- name: Add current directory to PATH
163+
run: echo "$PWD" >> "$GITHUB_PATH"
164+
- name: Set SHARDS_OVERRIDE
165+
run: echo "SHARDS_OVERRIDE=${GITHUB_WORKSPACE}/shard.override.yml" >> "$GITHUB_ENV"
166+
- name: Run e2e API app with authentication flow
167+
run: crystal spec spec/end_to_end/api_with_auth_spec.cr
180168

181-
# api_without_auth:
182-
# needs: [check_format, platform_specs]
183-
# strategy:
184-
# fail-fast: false
185-
# matrix:
186-
# include:
187-
# - { os: macos-latest }
188-
# - { os: windows-latest }
189-
# - { os: ubuntu-latest }
190-
# runs-on: ${{matrix.os}}
191-
# continue-on-error: false
192-
# steps:
193-
# - uses: actions/checkout@v6
194-
# - name: Setup PostgreSQL
195-
# uses: ikalnytskyi/action-setup-postgres@v8
196-
# with:
197-
# username: postgres
198-
# password: postgres
199-
# port: 5432
200-
# postgres-version: 18
201-
# - uses: crystal-lang/install-crystal@v1
202-
# with:
203-
# crystal: latest
204-
# - name: Install shards
205-
# run: shards install --skip-postinstall --skip-executables
206-
# - name: Install LuckyCLI
207-
# run: crystal build src/lucky.cr
208-
# - name: Add current directory to PATH
209-
# shell: bash
210-
# run: echo "$PWD" >> "$GITHUB_PATH"
211-
# - name: Run e2e API app without authentication flow
212-
# if: matrix.os == 'windows-latest'
213-
# run: |
214-
# $env:SHARDS_OVERRIDE = Join-Path -Path $pwd.Path -ChildPath "shard.override.yml"
215-
# crystal spec spec/end_to_end/api_no_auth_spec.cr
216-
# - name: Run e2e API app without authentication flow
217-
# if: matrix.os != 'windows-latest'
218-
# run: SHARDS_OVERRIDE="$(pwd)/shard.override.yml" crystal spec spec/end_to_end/api_no_auth_spec.cr
169+
api_without_auth:
170+
needs: [check_format, platform_specs]
171+
strategy:
172+
fail-fast: false
173+
matrix:
174+
include:
175+
- { os: ubuntu-latest }
176+
- { os: macos-latest }
177+
- { os: windows-latest }
178+
runs-on: ${{matrix.os}}
179+
continue-on-error: false
180+
steps:
181+
- uses: actions/checkout@v6
182+
- name: Setup PostgreSQL
183+
uses: ikalnytskyi/action-setup-postgres@v8
184+
with:
185+
username: postgres
186+
password: postgres
187+
port: 5432
188+
postgres-version: 18
189+
- uses: crystal-lang/install-crystal@v1
190+
with:
191+
crystal: latest
192+
- name: Install shards
193+
run: shards install --skip-postinstall --skip-executables
194+
- name: Install LuckyCLI
195+
run: crystal build src/lucky.cr
196+
- name: Add current directory to PATH
197+
run: echo "$PWD" >> "$GITHUB_PATH"
198+
- name: Set SHARDS_OVERRIDE
199+
run: echo "SHARDS_OVERRIDE=${GITHUB_WORKSPACE}/shard.override.yml" >> "$GITHUB_ENV"
200+
- name: Run e2e API app without authentication flow
201+
run: crystal spec spec/end_to_end/api_no_auth_spec.cr

0 commit comments

Comments
 (0)