Skip to content

Commit 2c919c4

Browse files
mvanhornlufftw
authored andcommitted
fix(mcp): drop unreachable throw in setTimeout-wrapped initial sync (zilliztech#318)
Remove throw in setTimeout callback that would crash the MCP server process on unexpected background sync errors. The error is already logged via console.error, and the periodic sync will retry on the next cycle.
1 parent aa9a5bc commit 2c919c4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/mcp/src/sync.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export class SyncManager {
126126
console.log('[SYNC-DEBUG] Collection not yet established, this is expected for new cluster users. Will retry on next sync cycle.');
127127
} else {
128128
console.error('[SYNC-DEBUG] Initial sync failed with unexpected error:', error);
129-
throw error;
129+
// Do not re-throw here: this callback runs via setTimeout with no caller to propagate to.
130130
}
131131
}
132132
}, 5000); // Initial sync after 5 seconds

0 commit comments

Comments
 (0)