Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates the workspace settings to better manage chat-related files, enforce consistent formatting, and guide commit message generation.
- Adds
chat.modeFilesLocations,chat.promptFilesLocations, andchat.instructionsFilesLocationsfor chat file management. - Enforces LF line endings, final newline insertion, and trailing whitespace trimming (with Markdown exceptions) plus a 100-character ruler.
- Defines Copilot commit message guidelines under
github.copilot.chat.commitMessageGeneration.instructions.
Comments suppressed due to low confidence (3)
.vscode/settings.json:26
- [nitpick] Consider aligning commit classification types with standard Conventional Commits (e.g.,
feat:,fix:,chore:) to ensure consistency with common workflows.
"github.copilot.chat.commitMessageGeneration.instructions": [
.vscode/settings.json:2
- The
chat.modeFilesLocations,chat.promptFilesLocations, andchat.instructionsFilesLocationssettings typically expect arrays or glob patterns rather than boolean flags. Please verify the extension's schema and update these configurations accordingly.
"chat.modeFilesLocations": {
.vscode/settings.json:2
- [nitpick] Indentation appears inconsistent with the rest of the file; align JSON keys to the project's two-space indent style for clarity and consistency.
"chat.modeFilesLocations": {
Comment on lines
+21
to
+25
| // "files.associations": { | ||
| // "*.chatmode.md": "markdown", | ||
| // "*.instructions.md": "markdown", | ||
| // "*.prompt.md": "markdown" | ||
| // }, |
There was a problem hiding this comment.
[nitpick] Commented-out file associations could be removed or moved to documentation to reduce clutter and keep the settings file focused.
Suggested change
| // "files.associations": { | |
| // "*.chatmode.md": "markdown", | |
| // "*.instructions.md": "markdown", | |
| // "*.prompt.md": "markdown" | |
| // }, | |
| // Removed the commented-out `files.associations` block to reduce clutter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.vscode/settings.jsonfile to introduce new configurations for managing chat-related files, enforce consistent file formatting, and provide guidelines for commit message generation.New configurations for chat-related files:
chat.modeFilesLocations,chat.promptFilesLocations, andchat.instructionsFilesLocationsto manage chat-related files (chatmodes,prompts, andinstructions).File formatting improvements:
\n), insert a final newline at the end of files, and trim trailing whitespace. Exceptions are made for Markdown files, where trailing whitespace is preserved, and formatting is applied on save.Editor enhancements:
Commit message guidelines:
CHORE:,FIX:, andBREAKING CHANGE:, as well as security and breaking change markers.