Noisy GEMM / Pearl#178
Closed
luminousmining wants to merge 9 commits into
Closed
Conversation
blake3.c is compiled into the standalone blake3_ref static library, whose
only include directory is its own cpu/ folder:
target_include_directories(blake3_ref PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
The project root (sources/) is not on that target's include path, so the
"use cast.hpp" change fails to build:
blake3.c:5:10: fatal error: 'common/cast.hpp' file not found
cast.hpp also transitively pulls in <chrono> and <CL/opencl.hpp> (under
AMD_ENABLE) — dependencies the canonical BLAKE3 reference library should
not carry.
The file is already built as C++ (project(blake3_ref CXX)), so the castU8()
helper buys nothing here. Revert to plain static_cast<uint8_t>, matching the
code that preceded the "use cast.hpp" commit. No new dependency, no CMake
include-path change.
Verified: blake3.c compiles clean as C++ with only cpu/ on the include path
(g++ -std=c++17 -c blake3.c -I.).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reverting castU8 -> static_cast<uint8_t> pushed the CHUNK_START/CHUNK_END argument line to 131 columns. Wrap it to stay within the project's 120-col limit, even though blake3.c (.c) is outside the clang-format target's *.cpp/*.hpp glob. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(blake3): drop cast.hpp from vendored blake3.c (#181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.