feat(clusters): load CA certificate data - #7
Merged
Conversation
Set the workspace and app crate edition to Rust 2024, update rustfmt configuration, and apply the resulting formatting changes across the app and kube crates. Collapse Clippy-reported nested conditionals and remove a redundant let binding so cargo clippy --workspace --all-targets -- -D warnings passes on the current toolchain.
Accept PEM or base64-encoded PEM CA data for token-based cluster entries, encode PEM data into kubeconfig certificate-authority-data, and reject CA data when TLS verification is skipped. Add a CA certificate file picker to the token cluster dialog and cover the new validation and encoding behavior with kubeconfig tests.
Merge origin/main into feat/token-cluster-ca-certificates so the CA certificate support branch includes the already-merged Rust 2024 cleanup, Pod image column, OpenConnect crate, and graphify documentation updates. Resolve the kubeconfig.rs conflict by keeping the base64 import required by CA certificate normalization while preserving the lint-clean import ordering from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept PEM or base64-encoded PEM CA data for token-based cluster entries, encode PEM data into kubeconfig certificate-authority-data, and reject CA data when TLS verification is skipped.
Add a CA certificate file picker to the token cluster dialog and cover the new validation and encoding behavior with kubeconfig tests.