feat(dock): add trash and stabilize autohide (#53)

* feat(dock): add trash and stabilize autohide

Add an optional trash icon to the dock, including live empty/full state, open and empty actions, drag-and-drop trashing, and a Nautilus fallback when the trash:// default handler is unavailable.

Improve dock visibility behavior so intellihide, hot-area reveal, hover autohide, overview transitions, and repeated show requests cooperate without flickering, stealing input while hidden, or leaving the dock stuck after switching between fullscreen or maximized windows.

Add Dock devtool controls for revealing, hiding, hot-area triggering, and toggling always-show mode per dock or per monitor, with shell coverage for the new controls.

Harden tray icon handling by keeping the Background Apps quick settings toggle hidden when configured, including when the toggle is created later.

Update release automation by replacing the GNOME backport workflow with a daily pre-release workflow, limiting release jobs to stable and rc tags, and isolating toolbox shell tests from host-scoped D-Bus services.

Add unit and shell tests for trash launching, intellihide state selection, dock hot-area/autohide edge cases, dock trash behavior, devtool actions, and Background Apps quick settings hiding.

Bump version-name to 51.0.

* fix(dock): restrict trash launch to Nautilus

Remove the trash:// default-handler path so the dock trash icon no longer opens alternate file managers selected by the system.

Track dash hover state without touching the dash container after it is destroyed, avoiding shutdown warnings from pending autohide timers.

Update trash launcher tests for the Nautilus-only contract and stop thedock shell test from requiring Nautilus in the test environment.

Author: leandromqrs

.github/workflows/gnome-backport.yml

@@ -0,0 +1,96 @@
+name: Pre-release
+
+on:
+  push:
+    branches: [main]
+
+permissions:
+  contents: write
+
+concurrency:
+  group: pre-release-main
+  cancel-in-progress: false
+
+jobs:
+  ci:
+    uses: ./.github/workflows/ci.yml
+
+  pre-release:
+    name: Create daily pre-release
+    runs-on: ubuntu-latest
+    needs: [ci]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Read version metadata
+        id: metadata
+        run: |
+          set -euo pipefail
+
+          VERSION_NAME="$(node -e 'const fs = require("fs"); const metadata = JSON.parse(fs.readFileSync("metadata.json", "utf8")); process.stdout.write(metadata["version-name"]);')"
+          RELEASE_DATE="$(date -u +%Y%m%d)"
+          RELEASE_NAME="${VERSION_NAME}-${RELEASE_DATE}"
+
+          echo "version_name=${VERSION_NAME}" >> "$GITHUB_OUTPUT"
+          echo "release_name=${RELEASE_NAME}" >> "$GITHUB_OUTPUT"
+          echo "tag_name=v${RELEASE_NAME}" >> "$GITHUB_OUTPUT"
+
+      - name: Download extension zip
+        uses: actions/download-artifact@v4
+        with:
+          name: extension-zip
+          path: dist/target/
+
+      - name: Configure Git
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
+
+      - name: Remove stale daily pre-releases
+        env:
+          GH_TOKEN: ${{ github.token }}
+          CURRENT_TAG: ${{ steps.metadata.outputs.tag_name }}
+        run: |
+          set -euo pipefail
+
+          gh release list --limit 100 --json tagName,isPrerelease --jq '
+            .[]
+            | select(.isPrerelease == true)
+            | .tagName
+          ' | while read -r tag; do
+            if [ -z "$tag" ] || [ "$tag" = "$CURRENT_TAG" ]; then
+              continue
+            fi
+
+            if [[ "$tag" =~ ^v[0-9]+\.[0-9]+-[0-9]{8}$ ]]; then
+              gh release delete "$tag" --yes --cleanup-tag
+            fi
+          done
+
+          git fetch --tags --force
+          git tag -l 'v*.*-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]' | while read -r tag; do
+            if [ -z "$tag" ] || [ "$tag" = "$CURRENT_TAG" ]; then
+              continue
+            fi
+
+            git push --delete origin "$tag" || true
+            git tag --delete "$tag" || true
+          done
+
+      - name: Move daily pre-release tag
+        run: |
+          set -euo pipefail
+          git tag --force "${{ steps.metadata.outputs.tag_name }}" "$GITHUB_SHA"
+          git push --force origin "refs/tags/${{ steps.metadata.outputs.tag_name }}"
+
+      - name: Create or update GitHub pre-release
+        uses: softprops/action-gh-release@v2
+        with:
+          tag_name: ${{ steps.metadata.outputs.tag_name }}
+          target_commitish: ${{ github.sha }}
+          name: ${{ steps.metadata.outputs.release_name }}
+          files: dist/target/aurora-shell@luminusos.github.io.shell-extension.zip
+          generate_release_notes: true
+          prerelease: true
+          make_latest: false
+          overwrite_files: true

.github/workflows/pre-release.yml

@@ -10,10 +10,12 @@ permissions:
 
 jobs:
   ci:
+    if: ${{ !contains(github.ref_name, '-') || contains(github.ref_name, '-rc') }}
     uses: ./.github/workflows/ci.yml
 
   release:
     name: Create GitHub Release
+    if: ${{ !contains(github.ref_name, '-') || contains(github.ref_name, '-rc') }}
     runs-on: ubuntu-latest
     needs: [ci]
     steps:
@@ -28,7 +30,7 @@ jobs:
       - name: Detect pre-release
         id: check
         run: |
-          if [[ "${{ github.ref_name }}" == *"-rc"* ]]; then
+          if [[ "${{ github.ref_name }}" == *"-"* ]]; then
             echo "prerelease=true" >> $GITHUB_OUTPUT
           else
             echo "prerelease=false" >> $GITHUB_OUTPUT
@@ -43,6 +45,7 @@ jobs:
           prerelease: ${{ steps.check.outputs.prerelease }}
 
       - name: Create maintenance branch
+        if: steps.check.outputs.prerelease == 'false'
         run: |
           MAJOR=$(echo "${{ github.ref_name }}" | sed 's/^v//' | grep -oP '^\d+')
           BRANCH="release/v${MAJOR}.x"

.github/workflows/release.yml

@@ -61,6 +61,11 @@
       <summary>Always show dock</summary>
       <description>Keep the dock permanently visible and reserve screen space so windows never overlap it</description>
     </key>
+    <key name="dock-show-trash" type="b">
+      <default>true</default>
+      <summary>Show trash icon</summary>
+      <description>Show a trash can icon in the dock; click to open the trash, right-click to empty it</description>
+    </key>
     <key name="module-auto-theme-switcher" type="b">
       <default>false</default>
       <summary>Enable Auto Theme Switcher module</summary>

data/schemas/org.gnome.shell.extensions.aurora-shell.gschema.xml

@@ -95,7 +95,7 @@ uninstall:
     @echo "Uninstalled."
 
 logs:
-    journalctl -b 0 /usr/bin/gnome-shell | grep "aurora"
+    journalctl -b 0 -r -o cat /usr/bin/gnome-shell | grep -i "aurora"
 
 clean:
     rm -rf dist
@@ -218,19 +218,16 @@ toolbox action *args:
                 echo "Example: just toolbox test tests/shell/auroraBasic.js"
                 exit 1
             fi
-            toolbox --container {{ toolbox_name }} run env GSETTINGS_SCHEMA_DIR=/usr/share/glib-2.0/schemas \
-                dbus-run-session gnome-shell-test-tool \
-                --headless --extension "$EXT" "$SCRIPT"
+            bash scripts/run-toolbox-shell-test.sh {{ toolbox_name }} "$EXT" "$SCRIPT"
             ;;
         "test-all")
             just package
             EXT="dist/target/{{ uuid }}.shell-extension.zip"
             PASS=0; FAIL=0
             for script in tests/shell/aurora*.js; do
                 echo "==> Running $script"
-                if toolbox --container {{ toolbox_name }} run env GSETTINGS_SCHEMA_DIR=/usr/share/glib-2.0/schemas \
-                        dbus-run-session gnome-shell-test-tool \
-                        --headless --extension "$EXT" "$script"; then
+                if bash scripts/run-toolbox-shell-test.sh \
+                        {{ toolbox_name }} "$EXT" "$script"; then
                     echo "    PASS: $script"
                     PASS=$((PASS + 1))
                 else

justfile

@@ -1,7 +1,7 @@
 {
     "name": "Aurora Shell",
     "description": "A customizable GNOME Shell extension that enhances the user experience with various modules and features. The optional Clipboard History module reads and stores clipboard text locally so it can be browsed and restored; no clipboard data is shared with third parties, and its open shortcut is unset by default.",
-    "version-name": "50.6",
+    "version-name": "51.0",
     "uuid": "aurora-shell@luminusos.github.io",
     "url": "https://github.com/luminusOS/aurora-shell",
     "settings-schema": "org.gnome.shell.extensions.aurora-shell",

metadata.json

@@ -7,6 +7,7 @@ IMAGE="${2:-registry.fedoraproject.org/fedora-toolbox:44}"
 
 PACKAGES=(
   gnome-shell
+  nautilus
   glib2-devel
   mutter-devkit
   mutter-tests

scripts/create-toolbox.sh

@@ -39,14 +39,21 @@ disable_dbus_service() {
   printf '[D-BUS Service]\nName=%s\nExec=/usr/bin/false\n' "$name" > "$service_dir/$name.service"
 }
 
-# A private session must not start a second keyring daemon: it cannot unlock the
-# host keyring and would display an authentication prompt inside the devkit.
+# A private session must not start host-scoped services whose state lives under
+# /run/user/$UID. In particular, a second document portal can invalidate the
+# host Flatpak document mount and leave Flatpak apps unable to start until the
+# host xdg-document-portal.service is restarted.
+disable_dbus_service org.freedesktop.portal.Documents
+
+# A second keyring daemon cannot unlock the host keyring and would display an
+# authentication prompt inside the devkit.
 disable_dbus_service org.freedesktop.secrets
 disable_dbus_service org.freedesktop.impl.portal.Secret
 disable_dbus_service org.gnome.keyring
 
 SHELL_ENV=(
   SHELL_DEBUG=all
+  G_MESSAGES_DEBUG="Aurora Shell"
   AURORA_DEVTOOLS=1
   XDG_CURRENT_DESKTOP=GNOME
   XDG_SESSION_TYPE=wayland

scripts/run-gnome-shell.sh

@@ -0,0 +1,43 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+TOOLBOX="$1"
+EXTENSION_ZIP="$2"
+TEST_SCRIPT="$3"
+HOST_RUNTIME_DIR="${XDG_RUNTIME_DIR:-/run/user/$(id -u)}"
+RUNTIME_DIR="$(mktemp -d "$HOST_RUNTIME_DIR/aurora-shell-test.XXXXXX")"
+PRIVATE_DATA_DIR="$RUNTIME_DIR/data"
+SERVICE_DIR="$PRIVATE_DATA_DIR/dbus-1/services"
+
+cleanup() {
+  rm -rf "$RUNTIME_DIR"
+}
+trap cleanup EXIT INT TERM
+
+chmod 700 "$RUNTIME_DIR"
+mkdir -p "$SERVICE_DIR"
+
+disable_dbus_service() {
+  local name="$1"
+  printf '[D-BUS Service]\nName=%s\nExec=/usr/bin/false\n' "$name" > "$SERVICE_DIR/$name.service"
+}
+
+# Never let a toolbox test claim the host Flatpak document portal or keyring.
+disable_dbus_service org.freedesktop.portal.Documents
+disable_dbus_service org.freedesktop.secrets
+disable_dbus_service org.freedesktop.impl.portal.Secret
+disable_dbus_service org.gnome.keyring
+
+toolbox --container "$TOOLBOX" run \
+  env \
+    -u DBUS_SESSION_BUS_ADDRESS \
+    -u DBUS_STARTER_ADDRESS \
+    -u DBUS_STARTER_BUS_TYPE \
+    XDG_RUNTIME_DIR="$RUNTIME_DIR" \
+    XDG_DATA_DIRS="$PRIVATE_DATA_DIR:${XDG_DATA_DIRS:-/usr/local/share:/usr/share}" \
+    GSETTINGS_SCHEMA_DIR=/usr/share/glib-2.0/schemas \
+    dbus-run-session gnome-shell-test-tool \
+      --headless \
+      --extension "$EXTENSION_ZIP" \
+      "$TEST_SCRIPT"