fix(tray): handle null values for app system and clean up menu references on destroy

Author: leandromqrs

src/modules/trayIcons/backgroundAppsSource.ts

@@ -37,7 +37,7 @@ export class BackgroundAppsSource {
   private _knownIds = new Map<string, TrayItem>();
   private _proxyChangedId = 0;
   private _callbacks: Callbacks;
-  private _appSystem: Shell.AppSystem;
+  private _appSystem: Shell.AppSystem | null;
   constructor(callbacks: Callbacks) {
     this._callbacks = callbacks;
     this._appSystem = Shell.AppSystem.get_default();
@@ -64,7 +64,7 @@ export class BackgroundAppsSource {
   }
 
   private _sync(): void {
-    if (!this._proxy) return;
+    if (!this._proxy || !this._appSystem) return;
 
     const backgroundApps = (this._proxy as any).BackgroundApps;
     const currentApps = new Map<string, { app: Shell.App; message: string | null }>();
@@ -153,6 +153,7 @@ export class BackgroundAppsSource {
       this._proxyChangedId = 0;
     }
     this._proxy = null;
+    this._appSystem = null;
     this._knownIds.clear();
   }
 }

src/modules/trayIcons/trayContainer.ts

@@ -163,6 +163,7 @@ export class TrayContainer extends PanelMenu.Button {
   declare private _userInteracted: boolean;
   declare private _attentionTimeoutSeconds: number;
   declare private _autoCollapseTimeoutId: number;
+  declare private _debugPostAllocateId: number;
   declare private _opacityTargets: WeakMap<TrayIconItem, number>;
   declare private _scrollTarget: number;
   declare private _smoothScrollAccumulator: number;
@@ -206,6 +207,7 @@ export class TrayContainer extends PanelMenu.Button {
     this._opacityTargets = new WeakMap();
     this._scrollTarget = 0;
     this._smoothScrollAccumulator = 0;
+    this._debugPostAllocateId = 0;
 
     // Chevron button (collapse/expand toggle)
     this._chevronIcon = new St.Icon({
@@ -569,7 +571,9 @@ export class TrayContainer extends PanelMenu.Button {
           );
         },
       );
-      GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
+      if (this._debugPostAllocateId > 0) GLib.Source.remove(this._debugPostAllocateId);
+      this._debugPostAllocateId = GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
+        this._debugPostAllocateId = 0;
         logger.log(
           `Viewport post-allocate chevronX=${Math.round(this._chevron.translationX)} ${this._clipArea.layoutSnapshot()}`,
           { prefix: LOG_PREFIX },
@@ -638,6 +642,10 @@ export class TrayContainer extends PanelMenu.Button {
       GLib.Source.remove(this._autoCollapseTimeoutId);
       this._autoCollapseTimeoutId = 0;
     }
+    if (this._debugPostAllocateId > 0) {
+      GLib.Source.remove(this._debugPostAllocateId);
+      this._debugPostAllocateId = 0;
+    }
     destroyTooltip();
     for (const widget of this._items.values()) widget.destroy();
     this._items.clear();

src/modules/trayIcons/trayIconItem.ts

@@ -266,7 +266,11 @@ export class TrayIconItem extends St.Button {
     _hideTooltip();
     this._dbusMenuClient?.destroy();
     this._menu?.destroy();
+    this._menu = null;
+    this._menuManager = null;
     this._localMenu?.destroy();
+    this._localMenu = null;
+    this._localMenuManager = null;
     this._trayItem.destroy();
     super.destroy();
   }