refactor: Simplify the module registration and remove the most boilerplate of the code (#61)

* refactor: remove boilerplate and simplify the way for registering modules

- Introduced unit tests for the `scoreIconWeaveCandidate` function to validate scoring logic based on various input scenarios.
- Added comprehensive tests for `ModuleManager` to ensure proper handling of module lifecycle, including enabling, disabling, and capability changes.
- Enhanced registry tests to ensure consistency between module definitions and GSettings schema.
- Updated runtime tests to reflect changes in module manifest structure and validation.
- Improved schema tests to validate XML structure and ensure all module keys are accounted for.

* feat: refactor dev tool UI components and improve modularity

- Introduced new utility functions in devToolUi.ts for creating UI components such as action buttons, summary panels, and action rows.
- Updated DockDevTool, GeneralDevTool, MeetingClockDevTool, TrayIconsDevTool, WeatherClockDevTool to utilize the new UI component functions, reducing code duplication and enhancing maintainability.
- Refactored device detection logic in device.ts for improved clarity and encapsulation of functionality.
- Added unit tests for app identity handling in appIdentity.test.ts to ensure correct behavior of app ID candidate generation.

* chore: update code structure and remove redundant changes

* fix: correct version name in metadata.json to match release version

* refactor: simplify CI workflows and remove deprecated container image configuration

* chore: update actions to latest versions in CI workflows

Author: leandromqrs

.dockerignore

@@ -0,0 +1,7 @@
+*
+!Containerfile
+!package.json
+!yarn.lock
+!.yarnrc.yml
+!.yarn/releases/
+!.yarn/releases/**

.github/actions/package-extension/action.yml

@@ -5,139 +5,156 @@ on:
   merge_group:
   workflow_call:
 
+permissions:
+  contents: read
+  packages: write
+
 concurrency:
   group: ci-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
+  ci-image:
+    name: CI image
+    runs-on: ubuntu-latest
+    outputs:
+      name: ${{ steps.image.outputs.name }}
+    steps:
+      - uses: actions/checkout@v7
+
+      - name: Log in to GHCR
+        uses: docker/login-action@v4
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Resolve CI image
+        id: image
+        run: |
+          IMAGE="$(bash scripts/ci-image-name.sh)"
+          echo "name=$IMAGE" >> "$GITHUB_OUTPUT"
+
+          if docker manifest inspect "$IMAGE" >/dev/null 2>&1; then
+            echo "exists=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "exists=false" >> "$GITHUB_OUTPUT"
+          fi
+
+      - uses: docker/setup-qemu-action@v4
+        if: steps.image.outputs.exists != 'true'
+
+      - uses: docker/setup-buildx-action@v4
+        if: steps.image.outputs.exists != 'true'
+
+      - name: Build and publish CI image
+        if: steps.image.outputs.exists != 'true'
+        uses: docker/build-push-action@v7
+        with:
+          context: .
+          file: Containerfile
+          platforms: linux/amd64,linux/arm64
+          push: true
+          tags: |
+            ${{ steps.image.outputs.name }}
+            ghcr.io/luminusos/aurora-shell-ci:sha-${{ github.sha }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
   lint:
     name: Validate
     runs-on: ubuntu-latest
+    needs: [ci-image]
+    container:
+      image: ${{ needs.ci-image.outputs.name }}
+      credentials:
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - uses: actions/checkout@v7
 
-      - name: Setup Yarn
-        uses: ./.github/actions/setup-yarn
-
-      - name: Install just
-        uses: extractions/setup-just@v4
+      - name: Install dependencies
+        run: just deps
 
       - name: Validate
         run: just validate
 
   unit-tests:
     name: Unit & regression tests
     runs-on: ubuntu-latest
+    needs: [ci-image]
+    container:
+      image: ${{ needs.ci-image.outputs.name }}
+      credentials:
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - uses: actions/checkout@v7
 
-      - name: Setup Yarn
-        uses: ./.github/actions/setup-yarn
+      - name: Install dependencies
+        run: just deps
 
       - name: Run unit tests
-        run: yarn test:unit
+        run: just unit-test
 
   build:
     name: Build
     runs-on: ubuntu-latest
-    needs: [lint]
+    needs: [ci-image, lint]
+    container:
+      image: ${{ needs.ci-image.outputs.name }}
+      credentials:
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - uses: actions/checkout@v7
 
-      - name: Package extension
-        uses: ./.github/actions/package-extension
+      - name: Install dependencies
+        run: just deps
+
+      - name: Build extension package
+        run: just package
 
       - name: Upload extension zip
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: extension-zip
           path: dist/target/aurora-shell@luminusos.github.io.shell-extension.zip
           retention-days: 1
 
   integration-tests:
-    name: Integration tests (GNOME ${{ matrix.gnome-version }})
+    name: Integration tests
     runs-on: ubuntu-latest
-    needs: [build, unit-tests]
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - gnome-version: '50'
-            container: 'fedora:44'
+    needs: [ci-image, build, unit-tests]
     container:
-      image: ${{ matrix.container }}
+      image: ${{ needs.ci-image.outputs.name }}
+      credentials:
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
       options: --privileged
     steps:
       - uses: actions/checkout@v7
 
       - name: Download extension zip
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: extension-zip
           path: dist/target/
 
-      - name: Install gnome-shell and test dependencies
-        run: |
-          dnf upgrade -y
-          dnf install -y --setopt=install_weak_deps=False \
-            gnome-shell \
-            dbus-daemon \
-            mesa-dri-drivers \
-            xorg-x11-server-Xvfb \
-            python3-dbusmock
-
       - name: Run integration tests
         env:
+          DISPLAY: ':0'
+          GDK_DEBUG: no-portals
           LIBGL_ALWAYS_SOFTWARE: '1'
+          WAYLAND_DISPLAY: gnome-shell-test-display
           XDG_RUNTIME_DIR: /tmp/xdg-runtime
-          DISPLAY: ':0'
-          WAYLAND_DISPLAY: 'gnome-shell-test-display'
-          # gnome-shell-perf-helper is a GTK4 app that times out (~25 s) trying
-          # to reach org.freedesktop.host.portal.Registry, which is not
-          # available in a headless test environment.  no-portals skips that
-          # lookup so the helper connects directly to the Wayland display and
-          # can exit gnome-shell cleanly.
-          GDK_DEBUG: 'no-portals'
         run: |
-          mkdir -p /tmp/xdg-runtime
-          chmod 700 /tmp/xdg-runtime
-
-          # Start a system D-Bus so GNOME Shell can reach Gio.DBus.system.
+          install -d -m 0700 "$XDG_RUNTIME_DIR"
           mkdir -p /run/dbus
           dbus-daemon --system --fork --nopidfile
-
-          # Mock org.freedesktop.login1 on the system bus. GNOME Shell 50's
-          # LoginManagerSystemd and EndSessionDialog create a proxy for this
-          # name synchronously at startup; without it the session crashes with
-          # "Launch helper exited with unknown return code 1".
           python3 -m dbusmock --system --template logind &
+          logind_pid=$!
+          trap 'kill "$logind_pid" 2>/dev/null || true' EXIT
           sleep 1
-
-          PASS=0; FAIL=0
-          for script in tests/shell/aurora*.js; do
-            echo "==> $script"
-            # dbus-update-activation-environment pushes display vars into the
-            # session bus daemon so that D-Bus-activated services (e.g.
-            # xdg-desktop-portal-gtk) inherit them and can connect to the
-            # Wayland compositor.  GDK_DEBUG=no-portals is also propagated so
-            # that gnome-shell-perf-helper (GTK4) skips the portal registry
-            # lookup that would otherwise time out in a headless environment.
-            if dbus-run-session bash -c '
-              dbus-update-activation-environment \
-                DISPLAY WAYLAND_DISPLAY XDG_RUNTIME_DIR LIBGL_ALWAYS_SOFTWARE \
-                GDK_DEBUG
-              exec gnome-shell-test-tool \
-                --headless \
-                --extension dist/target/aurora-shell@luminusos.github.io.shell-extension.zip \
-                "$1"
-            ' -- "$script"; then
-              echo "    PASS"
-              PASS=$((PASS + 1))
-            else
-              echo "    FAIL"
-              FAIL=$((FAIL + 1))
-            fi
-          done
-          echo ""
-          echo "Results: $PASS passed, $FAIL failed"
-          [ "$FAIL" -eq 0 ]
+          bash scripts/run-shell-tests.sh \
+            dist/target/aurora-shell@luminusos.github.io.shell-extension.zip

.github/actions/setup-yarn/action.yml

@@ -6,20 +6,28 @@ on:
 
 permissions:
   contents: write
+  packages: write
 
 concurrency:
   group: pre-release-main
   cancel-in-progress: true
 
 jobs:
+  ci:
+    uses: ./.github/workflows/ci.yml
+
   pre-release:
     name: Create nightly pre-release
     runs-on: ubuntu-latest
+    needs: [ci]
     steps:
       - uses: actions/checkout@v7
 
-      - name: Package extension
-        uses: ./.github/actions/package-extension
+      - name: Download extension zip
+        uses: actions/download-artifact@v8
+        with:
+          name: extension-zip
+          path: dist/target/
 
       - name: Read version metadata
         id: metadata

.github/workflows/ci.yml

@@ -7,6 +7,7 @@ on:
 
 permissions:
   contents: write
+  packages: write
 
 jobs:
   ci:
@@ -22,7 +23,7 @@ jobs:
       - uses: actions/checkout@v7
 
       - name: Download extension zip
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: extension-zip
           path: dist/target/

.github/workflows/pre-release.yml

@@ -12,8 +12,6 @@ node_modules/
 
 # Build output
 dist/
-dist-gjsify/
-dist-gjsify-probe/
 
 # npm (legacy)
 package-lock.json
@@ -42,4 +40,4 @@ docs/
 
 # IA Stuff
 .agents/
-skills-lock.json
+skills-lock.json