fix: Update version-name to 50.5 and refactor clipboard loading (#43)

* feat(metadata): update version-name to 50.4

* feat(clipboard): refactor loading mechanism to use async methods for clipboard store

* feat(metadata): update version-name to 50.5

Author: leandromqrs

metadata.json

@@ -1,7 +1,7 @@
 {
     "name": "Aurora Shell",
     "description": "A customizable GNOME Shell extension that enhances the user experience with various modules and features. The optional Clipboard History module reads and stores clipboard text locally so it can be browsed and restored; no clipboard data is shared with third parties, and its open shortcut is unset by default.",
-    "version-name": "50.2",
+    "version-name": "50.5",
     "uuid": "aurora-shell@luminusos.github.io",
     "url": "https://github.com/luminusOS/aurora-shell",
     "settings-schema": "org.gnome.shell.extensions.aurora-shell",

src/modules/clipboardHistory/clipboardHistory.ts

@@ -39,7 +39,6 @@ export class ClipboardHistory extends Module {
     const pollMs = rawSettings.get_int('clipboard-history-poll-interval');
 
     this._store = new ClipboardStore(filePath, maxItems);
-    this._store.load();
 
     this._panel = new (ClipboardPanel as unknown as new (
       store: ClipboardStore,
@@ -56,6 +55,8 @@ export class ClipboardHistory extends Module {
 
     this._monitor = new ClipboardMonitor(pollMs, (text) => this.addText(text));
 
+    void this._store.load().then(() => this._panel?.refresh());
+
     this._startupIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
       this._startupIdleId = 0;
       this._monitor?.start();

src/modules/clipboardHistory/clipboardStore.ts

@@ -5,6 +5,9 @@ import Gio from '@girs/gio-2.0';
 
 import { logger } from '~/core/logger.ts';
 
+// @ts-ignore - _promisify is a GJS extension not reflected in .d.ts
+Gio._promisify(Gio.File.prototype, 'load_contents_async');
+
 const LOG_PREFIX = 'ClipboardHistory';
 
 export type ClipboardEntry = {
@@ -31,12 +34,11 @@ export class ClipboardStore {
     this._maxItems = maxItems;
   }
 
-  load(): void {
+  async load(): Promise<void> {
     try {
       const file = Gio.File.new_for_path(this._filePath);
-      const [ok, contents] = file.load_contents(null);
-      if (!ok) return;
-      const decoded = new TextDecoder().decode(contents as unknown as Uint8Array);
+      const [contents] = await file.load_contents_async(null);
+      const decoded = new TextDecoder().decode(contents);
       const parsed = JSON.parse(decoded) as StorageFormat;
       if (parsed.version !== 1 || !Array.isArray(parsed.entries)) return;
       this._pinned = parsed.entries.filter((e) => e.pinned);

src/modules/trayIcons/trayContainer.ts

@@ -155,7 +155,7 @@ export class TrayContainer extends PanelMenu.Button {
   declare private _limit: number;
   declare private _items: Map<string, TrayIconItem>;
   declare private _chevron: St.Button;
-  declare private _chevronIcon: St.Icon;
+  declare private _chevronIcon: St.Icon | null;
   declare private _clipArea: TrayClipArea;
   declare private _iconRow: St.BoxLayout;
   declare private _outerBox: St.BoxLayout;
@@ -495,7 +495,7 @@ export class TrayContainer extends PanelMenu.Button {
     this._chevron.visible = hasOverflow;
 
     // Chevron rotation: 0° = expanded (points right), 180° = collapsed (points left).
-    this._chevronIcon.ease({
+    this._chevronIcon?.ease({
       rotationAngleZ: this._state.collapsed ? 180 : 0,
       duration: animated ? ANIM_DURATION : 0,
       mode: Clutter.AnimationMode.EASE_OUT_CUBIC,
@@ -648,6 +648,8 @@ export class TrayContainer extends PanelMenu.Button {
     destroyTooltip();
     for (const widget of this._items.values()) widget.destroy();
     this._items.clear();
+    this._chevronIcon?.destroy();
+    this._chevronIcon = null;
     super.destroy();
   }
 }

src/modules/trayIcons/trayIcons.ts

@@ -9,6 +9,8 @@ import type { Button as PanelMenuButton } from '@girs/gnome-shell/ui/panelMenu';
 
 // @ts-ignore
 Gio._promisify(Gio.DBusConnection.prototype, 'call');
+// @ts-ignore - _promisify is a GJS extension not reflected in .d.ts
+Gio._promisify(Gio.File.prototype, 'load_contents_async');
 
 import type { ExtensionContext } from '~/core/context.ts';
 import { logger } from '~/core/logger.ts';
@@ -268,9 +270,9 @@ export class TrayIcons extends Module {
       if (!sniPid) continue;
 
       const directMatch = appPidSet.has(sniPid);
-      const ancestorMatch = directMatch ? true : this._pidHasAncestor(sniPid, appPidSet);
+      const ancestorMatch = directMatch ? true : await this._pidHasAncestor(sniPid, appPidSet);
       const trackerMatch = this._trackedPidMatchesApp(sniPid, appId, app);
-      const flatpakAppId = this._getFlatpakAppId(sniPid);
+      const flatpakAppId = await this._getFlatpakAppId(sniPid);
       const flatpakMatch = flatpakAppId ? appIdCandidates.has(flatpakAppId.toLowerCase()) : false;
       const covered = ancestorMatch || trackerMatch || flatpakMatch;
       logger.log(
@@ -283,13 +285,19 @@ export class TrayIcons extends Module {
     return false;
   }
 
-  private _getFlatpakAppId(pid: number): string | null {
+  private async _getFlatpakAppId(pid: number): Promise<string | null> {
+    const text = await this._readProcText(`/proc/${pid}/root/.flatpak-info`);
+    if (!text) return null;
+    const match = /^name=(.+)$/m.exec(text);
+    return match?.[1]?.trim() || null;
+  }
+
+  // Async /proc read (EGO-X-004: no synchronous file IO in shell code).
+  private async _readProcText(path: string): Promise<string | null> {
     try {
-      const [ok, bytes] = GLib.file_get_contents(`/proc/${pid}/root/.flatpak-info`);
-      if (!ok) return null;
-      const text = new TextDecoder().decode(bytes);
-      const match = /^name=(.+)$/m.exec(text);
-      return match?.[1]?.trim() || null;
+      const file = Gio.File.new_for_path(path);
+      const [contents] = await file.load_contents_async(null);
+      return new TextDecoder().decode(contents);
     } catch {
       return null;
     }
@@ -306,13 +314,13 @@ export class TrayIcons extends Module {
     }
   }
 
-  private _pidHasAncestor(pid: number, candidateAncestors: Set<number>): boolean {
+  private async _pidHasAncestor(pid: number, candidateAncestors: Set<number>): Promise<boolean> {
     let currentPid = pid;
     const seen = new Set<number>();
 
     while (currentPid > 1 && !seen.has(currentPid)) {
       seen.add(currentPid);
-      const parentPid = this._getParentPid(currentPid);
+      const parentPid = await this._getParentPid(currentPid);
       if (!parentPid) return false;
       if (candidateAncestors.has(parentPid)) return true;
       currentPid = parentPid;
@@ -321,17 +329,12 @@ export class TrayIcons extends Module {
     return false;
   }
 
-  private _getParentPid(pid: number): number | null {
-    try {
-      const [ok, bytes] = GLib.file_get_contents(`/proc/${pid}/status`);
-      if (!ok) return null;
-      const text = new TextDecoder().decode(bytes);
-      const match = /^PPid:\s+(\d+)$/m.exec(text);
-      if (!match) return null;
-      return Number.parseInt(match[1]!, 10);
-    } catch {
-      return null;
-    }
+  private async _getParentPid(pid: number): Promise<number | null> {
+    const text = await this._readProcText(`/proc/${pid}/status`);
+    if (!text) return null;
+    const match = /^PPid:\s+(\d+)$/m.exec(text);
+    if (!match) return null;
+    return Number.parseInt(match[1]!, 10);
   }
 
   private _appIdCandidates(appId: string, app: Shell.App): Set<string> {

src/modules/volumeMixer/mixerPanel.ts

@@ -66,11 +66,6 @@ export class VolumeMixerPanel extends St.BoxLayout {
     this._emptyLabel.visible = !hasStreams;
   }
 
-  override vfunc_destroy(): void {
-    this._scroll = null;
-    super.vfunc_destroy();
-  }
-
   override vfunc_get_preferred_height(forWidth: number): [number, number] {
     if (!this.get_stage()) return [0, 0];
 

src/shared/ui/dash.ts

@@ -209,16 +209,17 @@ export class AuroraDash extends Dash {
   }
 
   private _syncLabelFlushMode(): void {
-    const items: any[] = [
-      ...((this as any)._box?.get_children?.() ?? []),
-      (this as any)._showAppsIcon,
-    ];
+    const items: any[] = [...this._getDashChildren(), (this as any)._showAppsIcon];
     for (const item of items) {
-      if (!item?.label) continue;
-      if (this._flushMode) {
-        item.label.add_style_class_name('flush-mode');
-      } else {
-        item.label.remove_style_class_name('flush-mode');
+      try {
+        if (!item?.label) continue;
+        if (this._flushMode) {
+          item.label.add_style_class_name('flush-mode');
+        } else {
+          item.label.remove_style_class_name('flush-mode');
+        }
+      } catch {
+        // Ignore children disposed during shell shutdown.
       }
     }
   }
@@ -340,10 +341,15 @@ export class AuroraDash extends Dash {
 
   private _isMenuOpen(): boolean {
     const dashAny = this as any;
-    const children = dashAny._box?.get_children?.() ?? [];
+    const children = this._getDashChildren();
 
     for (const child of children) {
-      const appIcon = child.child?._delegate;
+      let appIcon: any;
+      try {
+        appIcon = child.child?._delegate;
+      } catch {
+        continue;
+      }
 
       if (appIcon?._menu?.isOpen) {
         return true;
@@ -499,11 +505,15 @@ export class AuroraDash extends Dash {
     // Snapshot existing (non-animating-out) apps so we can detect newly added
     // items after stock _redisplay and animate them in ourselves.
     const isFirstDisplay = !dashAny._shownInitially;
-    const existingApps = new Set<any>(
-      ((this as any)._box?.get_children?.() ?? [])
-        .filter((c: any) => c.child?._delegate?.app && !c.animatingOut)
-        .map((c: any) => c.child._delegate.app),
-    );
+    const existingApps = new Set<any>();
+    for (const child of this._getDashChildren()) {
+      try {
+        const app = child.child?._delegate?.app;
+        if (app && !child.animatingOut) existingApps.add(app);
+      } catch {
+        // Ignore children disposed during shell shutdown.
+      }
+    }
 
     // Temporarily patch get_running() so the base Dash only sees apps with
     // windows on this monitor and active workspace. _globallyRunningIds is set
@@ -557,21 +567,24 @@ export class AuroraDash extends Dash {
     // (instant) when overview.visible is false, leaving new items at scale=1.
     // We detect them via the pre-redisplay snapshot and replay the animation.
     if (shouldAnimate && !isFirstDisplay) {
-      const children = (this as any)._box?.get_children?.() ?? [];
-      for (const child of children) {
-        const childApp = child.child?._delegate?.app;
-        if (childApp && !existingApps.has(childApp) && !child.animatingOut) {
-          child.remove_all_transitions();
-          child.scale_x = 0;
-          child.scale_y = 0;
-          child.opacity = 0;
-          child.ease({
-            scale_x: 1,
-            scale_y: 1,
-            opacity: 255,
-            duration: ANIMATION_TIME,
-            mode: Clutter.AnimationMode.EASE_OUT_QUAD,
-          });
+      for (const child of this._getDashChildren()) {
+        try {
+          const childApp = child.child?._delegate?.app;
+          if (childApp && !existingApps.has(childApp) && !child.animatingOut) {
+            child.remove_all_transitions();
+            child.scale_x = 0;
+            child.scale_y = 0;
+            child.opacity = 0;
+            child.ease({
+              scale_x: 1,
+              scale_y: 1,
+              opacity: 255,
+              duration: ANIMATION_TIME,
+              mode: Clutter.AnimationMode.EASE_OUT_QUAD,
+            });
+          }
+        } catch {
+          // Ignore children disposed during shell shutdown.
         }
       }
     }
@@ -605,13 +618,16 @@ export class AuroraDash extends Dash {
   }
 
   private _updatePerMonitorRunningDots(): void {
-    const children = (this as any)._box?.get_children?.() ?? [];
-    for (const child of children) {
-      const icon = child.child?._delegate;
-      if (!icon?.app) continue;
-      const hasWindowHere = icon.app.get_windows().some((w: any) => this._isWindowRelevant(w));
-      const dot = icon._dot;
-      if (dot) dot.visible = hasWindowHere;
+    for (const child of this._getDashChildren()) {
+      try {
+        const icon = child.child?._delegate;
+        if (!icon?.app) continue;
+        const hasWindowHere = icon.app.get_windows().some((w: any) => this._isWindowRelevant(w));
+        const dot = icon._dot;
+        if (dot) dot.visible = hasWindowHere;
+      } catch {
+        // Ignore children disposed during shell shutdown.
+      }
     }
   }
 
@@ -625,9 +641,13 @@ export class AuroraDash extends Dash {
    * clicked a window directly or switched apps).
    */
   private _overrideIconActivation(): void {
-    const children = (this as any)._box?.get_children?.() ?? [];
-    for (const child of children) {
-      const appIcon = child.child?._delegate;
+    for (const child of this._getDashChildren()) {
+      let appIcon: any;
+      try {
+        appIcon = child.child?._delegate;
+      } catch {
+        continue;
+      }
       if (!appIcon?.app || appIcon._auroraActivatePatched) continue;
 
       appIcon._auroraActivatePatched = true;
@@ -720,6 +740,15 @@ export class AuroraDash extends Dash {
     }
   }
 
+  private _getDashChildren(): any[] {
+    if (this._isDestroyed) return [];
+    try {
+      return (this as any)._box?.get_children?.() ?? [];
+    } catch {
+      return [];
+    }
+  }
+
   private _setupSpringLoadMonitor(): void {
     this._springLoadDragMonitor = {
       dragMotion: (dragEvent: any) => {