fix: centralize module instantiation using MODULE_FACTORIES to fix settings not showing

Author: leandromqrs

src/extension.ts

@@ -7,6 +7,18 @@ import { Extension } from "@girs/gnome-shell/extensions/extension";
 import type { Module } from "./module.ts";
 import { MODULE_REGISTRY, type ModuleDefinition } from "./registry.ts";
 
+import { ThemeChanger } from "./modules/themeChanger.ts";
+import { Dock } from "./modules/dock.ts";
+import { NoOverview } from "./modules/noOverview.ts";
+import { PipOnTop } from "./modules/pipOnTop.ts";
+
+const MODULE_FACTORIES: Record<string, () => Module> = {
+  themeChanger: () => new ThemeChanger(),
+  dock: () => new Dock(),
+  noOverview: () => new NoOverview(),
+  pipOnTop: () => new PipOnTop(),
+};
+
 /**
  * Aurora Shell Extension
  *
@@ -30,7 +42,7 @@ export default class AuroraShellExtension extends Extension {
   private _initializeModules(): void {
     for (const def of MODULE_REGISTRY) {
       if (this._settings?.get_boolean(def.settingsKey)) {
-        this._modules.set(def.key, def.create());
+        this._modules.set(def.key, MODULE_FACTORIES[def.key]());
       }
     }
   }
@@ -63,7 +75,7 @@ export default class AuroraShellExtension extends Extension {
     if (enabled && !existing) {
       console.log(`Aurora Shell: Enabling module ${def.key}`);
       try {
-        const module = def.create();
+        const module = MODULE_FACTORIES[def.key]();
         module.enable();
         this._modules.set(def.key, module);
       } catch (e) {

src/registry.ts

@@ -1,9 +1,3 @@
-import { ThemeChanger } from "./modules/themeChanger.ts";
-import { Dock } from "./modules/dock.ts";
-import { NoOverview } from "./modules/noOverview.ts";
-import { PipOnTop } from "./modules/pipOnTop.ts";
-import type { Module } from "./module.ts";
-
 /**
  * Module definition that includes both runtime and UI metadata
  */
@@ -12,8 +6,6 @@ export type ModuleDefinition = {
   key: string;
   /** GSettings schema key */
   settingsKey: string;
-  /** Factory function to create module instance */
-  create: () => Module;
   /** User-facing title for preferences UI */
   title: string;
   /** User-facing subtitle/description for preferences UI */
@@ -23,36 +15,32 @@ export type ModuleDefinition = {
 /**
  * Single source of truth for all available modules.
  * To add a new module:
- * 1. Import its class at the top
- * 2. Add one entry to this array
+ * 1. Add one entry to this array
+ * 2. Add a factory entry in extension.ts MODULE_FACTORIES
  * 3. Add corresponding key to gschema.xml
  */
 export const MODULE_REGISTRY: ModuleDefinition[] = [
   {
     key: 'themeChanger',
     settingsKey: 'module-theme-changer',
-    create: () => new ThemeChanger(),
     title: 'Theme Changer',
     subtitle: 'Monitors and synchronizes GNOME color scheme',
   },
   {
     key: 'dock',
     settingsKey: 'module-dock',
-    create: () => new Dock(),
     title: 'Dock',
     subtitle: 'Custom dock with auto-hide and intellihide features',
   },
   {
     key: 'noOverview',
     settingsKey: 'module-no-overview',
-    create: () => new NoOverview(),
     title: 'No Overview',
     subtitle: 'Disables the overview at startup',
   },
   {
     key: 'pipOnTop',
     settingsKey: 'module-pip-on-top',
-    create: () => new PipOnTop(),
     title: 'Pip On Top',
     subtitle: 'Keeps Picture-in-Picture windows always on top',
   },