Fix database compatibility issue with PRAGMA commands

Author: lunaticsm

app/db.py

@@ -19,31 +19,48 @@ def init_db() -> None:
 def ensure_schema_compatibility():
     """Ensure the database schema is compatible with current models, adding missing columns if needed."""
     with engine.connect() as conn:
-        # Check if permanent column exists in file table by querying table info
         try:
-            result = conn.execute(text("PRAGMA table_info(file)")).fetchall()
-            column_names = [row[1] for row in result]  # Second column in PRAGMA is column name
-            if 'permanent' not in column_names:
-                # For SQLite, we need to recreate the table with the new column
-                # First, backup existing data
-                conn.execute(text("ALTER TABLE file RENAME TO file_backup"))
-                
-                # Create new table with permanent column
-                SQLModel.metadata.tables['file'].create(conn)
-                
-                # Copy data from backup to new table, setting permanent to false for existing records
-                conn.execute(text("""
-                    INSERT INTO file (id, original_name, stored_name, content_type, size_bytes, permanent, created_at)
-                    SELECT id, original_name, stored_name, content_type, size_bytes, 0, created_at 
-                    FROM file_backup
-                """))
-                
-                # Drop backup table
-                conn.execute(text("DROP TABLE file_backup"))
-                conn.commit()
-                logging.info("Migrated 'file' table to include 'permanent' column")
+            # Check if database is SQLite or PostgreSQL and use appropriate approach
+            if 'sqlite' in DB_URL.lower():
+                # SQLite-specific approach
+                result = conn.execute(text("PRAGMA table_info(file)")).fetchall()
+                column_names = [row[1] for row in result]  # Second column in PRAGMA is column name
+                if 'permanent' not in column_names:
+                    # For SQLite, we need to recreate the table with the new column
+                    # First, backup existing data
+                    conn.execute(text("ALTER TABLE file RENAME TO file_backup"))
+
+                    # Create new table with permanent column
+                    SQLModel.metadata.tables['file'].create(conn)
+
+                    # Copy data from backup to new table, setting permanent to false for existing records
+                    conn.execute(text("""
+                        INSERT INTO file (id, original_name, stored_name, content_type, size_bytes, permanent, created_at)
+                        SELECT id, original_name, stored_name, content_type, size_bytes, 0, created_at
+                        FROM file_backup
+                    """))
+
+                    # Drop backup table
+                    conn.execute(text("DROP TABLE file_backup"))
+                    conn.commit()
+                    logging.info("Migrated 'file' table to include 'permanent' column")
+                else:
+                    logging.info("Database schema is up to date")
             else:
-                logging.info("Database schema is up to date")
+                # PostgreSQL-specific approach
+                result = conn.execute(text("""
+                    SELECT column_name
+                    FROM information_schema.columns
+                    WHERE table_name = 'file' AND column_name = 'permanent'
+                """)).fetchall()
+
+                if not result:
+                    # Add the permanent column to the file table
+                    conn.execute(text("ALTER TABLE file ADD COLUMN permanent BOOLEAN DEFAULT FALSE"))
+                    conn.commit()
+                    logging.info("Migrated 'file' table to include 'permanent' column")
+                else:
+                    logging.info("Database schema is up to date")
         except OperationalError as e:
             logging.warning(f"Could not check or migrate database schema: {e}")
 

test_upload.txt

@@ -0,0 +1 @@
+This is a test file for upload functionality.