fix(manager): use timingSafeEqual for password comparisons#22
Open
codejunkie99 wants to merge 1 commit into
Open
fix(manager): use timingSafeEqual for password comparisons#22codejunkie99 wants to merge 1 commit into
codejunkie99 wants to merge 1 commit into
Conversation
- manager/src/index.ts:1442 (legacy admin auth) - manager/src/index.ts:3527 (admin login POST) - manager/src/index.ts:3963 (gateway control WS auth) Matches the pattern already used in verifyJwtToken at :397.
|
Same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Password comparisons use
===, which is not constant-time and leakstiming information on matching-prefix length.
Where
manager/src/index.ts:1442— legacy admin authmanager/src/index.ts:3527— admin login POSTmanager/src/index.ts:3963— gateway control WS authFix
Swap
===forcrypto.timingSafeEqual. The symbol is already importedat line 3 and used correctly in
verifyJwtTokenat line 397, this justmakes the other three spots consistent.
Risk
None. Same behavior on the happy path, no protocol change, no new deps.