LUT-32919 : CSRF token and open redirect control on comment add/remove#21
Open
FrancoisEricMerlin wants to merge 1 commit into
Open
Conversation
Add a per-resource CSRF security token (SecurityTokenService) to the doAddComment action and align the removeComment token on the same ( idExtendableResource, extendableResourceType ) couple. Guard both redirections (redirectToLastUrl, doRemoveComment) with SecurityUtil.isInternalRedirectUrlSafe to prevent open redirect via the from_url parameter, with fallback to the site base URL.
FrancoisEricMerlin
force-pushed
the
LUT-32919-develop_core7
branch
from
July 8, 2026 10:52
301fbec to
03914de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Open Redirect via CSRF reported on the extend-comment module.
Redmine: https://dev.lutece.paris.fr/bugtracker/issues/32919