Skip to content

LUT-31765 : Update technical admin right level for deleting questions#637

Open
antoinefuzier wants to merge 1 commit into
lutece-platform:develop_core7from
antoinefuzier:LUT-31765
Open

LUT-31765 : Update technical admin right level for deleting questions#637
antoinefuzier wants to merge 1 commit into
lutece-platform:develop_core7from
antoinefuzier:LUT-31765

Conversation

@antoinefuzier

Copy link
Copy Markdown
Contributor

No description provided.

private static final String ILLUSTRATION_IMAGE = "illustration_image";
private static final FormService _formService = SpringContextService.getBean( FormService.BEAN_NAME );
private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 0;
private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 1;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should elaborate a bit on that solution cause it's hard coding, and hard coding is bad (most of the time).

I see two options:

  • do not check level at all and just rely on RBAC
  • check level, but smart, tracking the user level used to create the form, and check against it. This is relevant only if checking the admin level is really needed.

The second option could be covered by adding an creation_level column in forms_form, and managing it in the code:

if ( adminUser != null && adminUser.getUserLevel( ) > form.getCreationLevel( ) )
        {
        	return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
        }

instead of current

if ( adminUser != null && adminUser.getUserLevel( ) != TECHNICAL_ADMIN_RIGHT_LEVEL )
        {
        	return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants