LUT-31765 : Update technical admin right level for deleting questions#637
Open
antoinefuzier wants to merge 1 commit into
Open
LUT-31765 : Update technical admin right level for deleting questions#637antoinefuzier wants to merge 1 commit into
antoinefuzier wants to merge 1 commit into
Conversation
lobtx
suggested changes
Jul 17, 2026
| private static final String ILLUSTRATION_IMAGE = "illustration_image"; | ||
| private static final FormService _formService = SpringContextService.getBean( FormService.BEAN_NAME ); | ||
| private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 0; | ||
| private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 1; |
Contributor
There was a problem hiding this comment.
I think we should elaborate a bit on that solution cause it's hard coding, and hard coding is bad (most of the time).
I see two options:
- do not check level at all and just rely on RBAC
- check level, but smart, tracking the user level used to create the form, and check against it. This is relevant only if checking the admin level is really needed.
The second option could be covered by adding an creation_level column in forms_form, and managing it in the code:
if ( adminUser != null && adminUser.getUserLevel( ) > form.getCreationLevel( ) )
{
return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
}instead of current
if ( adminUser != null && adminUser.getUserLevel( ) != TECHNICAL_ADMIN_RIGHT_LEVEL )
{
return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
}
lobtx
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.