Skip to content

LUT-31765 : Update technical admin right level for deleting questions #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoinefuzier wants to merge 1 commit into
base: develop_core7
Choose a base branch
from
Open

LUT-31765 : Update technical admin right level for deleting questions #637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java/fr/paris/lutece/plugins/forms/web/admin/FormQuestionJspBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public class FormQuestionJspBean extends AbstractFormQuestionJspBean
private static final String PUBLIC_IMAGE_RESOURCE = "public_image_resource";
private static final String ILLUSTRATION_IMAGE = "illustration_image";
private static final FormService _formService = SpringContextService.getBean( FormService.BEAN_NAME );
private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 0;
private static final int TECHNICAL_ADMIN_RIGHT_LEVEL = 1;

@lobtx lobtx Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should elaborate a bit on that solution cause it's hard coding, and hard coding is bad (most of the time).

I see two options:

  • do not check level at all and just rely on RBAC
  • check level, but smart, tracking the user level used to create the form, and check against it. This is relevant only if checking the admin level is really needed.

The second option could be covered by adding an creation_level column in forms_form, and managing it in the code:

if ( adminUser != null && adminUser.getUserLevel( ) > form.getCreationLevel( ) )
        {
        	return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
        }

instead of current

if ( adminUser != null && adminUser.getUserLevel( ) != TECHNICAL_ADMIN_RIGHT_LEVEL )
        {
        	return redirect( request, AdminMessageService.getMessageUrl( request, WARNING_INSUFFICIENT_RIGHTS_LEVEL_TO_DELETE_COMPOSITE, AdminMessage.TYPE_STOP ) );
        }

private Form _form;

/**
Expand Down