test(tray): budget the socket-inheritance proof for what it actually does

The test failed on windows-latest at 5159ms. Production allows
PowerShell 15s (execFileSync timeout in src/tray/windows.ts), while
Bun's default test budget is 5s, and a contended runner lands between
the two. The test was failing having done nothing wrong.

Raising a budget is not the general answer to a flaky test, and this
round is the reason to say so out loud: the sidebar route tests were
fixed earlier today by DELETING their real gh spawn, because spawning a
binary was incidental to what they claimed. Here the opposite holds.
This test launches PowerShell, which launches a Bun child, then rebinds
the port to prove the child never inherited the listen socket. The
processes are the assertion. There is no version of this proof that
fakes them, so the only honest fix is a budget that covers the work.

The distinction worth carrying forward is whether the wait is intrinsic
to the assertion. It is here; it was not there.

The pid-file wait becomes deadline-based rather than a fixed 100x25ms
count, and says what went wrong on timeout. A bare false told you the
file was missing and nothing about whether PowerShell never started, the
child died, or the runner was just slow.

No assertion changed: both process.kill liveness checks and the port
rebind are untouched.

Author: lidge-jun

tests/windows-tray.test.ts

@@ -244,6 +244,22 @@ describe("Windows tray packaging and command safety", () => {
     expect(source).not.toContain("Stop-Process");
   });
 
+  // This test really does launch PowerShell, which really does launch a Bun child, and
+  // then rebinds the port to prove the child did not inherit the listen socket. Those
+  // processes ARE the assertion — there is no version of this proof that fakes them.
+  //
+  // So the budget has to cover work the test genuinely performs. Production allows
+  // PowerShell 15s (`execFileSync` timeout in src/tray/windows.ts), while Bun's default
+  // test budget is 5s; a contended windows-latest runner lands between the two and the
+  // test fails at ~5.1s having done nothing wrong.
+  //
+  // Raising a budget is NOT the general answer to a flaky test. Earlier in this same
+  // round the sidebar route tests were fixed by DELETING their real `gh` spawn, because
+  // spawning a binary was incidental to what those tests claimed. The distinction is
+  // whether the wait is intrinsic to the assertion. Here it is; there it was not.
+  const PID_FILE_WAIT_MS = 20_000;
+  const TRAY_LAUNCH_TIMEOUT_MS = 45_000;
+
   test("launches the detached tray host without retaining the proxy listen socket", async () => {
     if (process.platform !== "win32") return;
     const directory = mkdtempSync(join(tmpdir(), "ocx-tray-inheritance-"));
@@ -267,10 +283,17 @@ describe("Windows tray packaging and command safety", () => {
         bun: process.execPath,
         cli: childPath,
       });
-      for (let attempt = 0; attempt < 100 && !existsSync(pidPath); attempt += 1) {
+      const pidDeadline = Date.now() + PID_FILE_WAIT_MS;
+      while (!existsSync(pidPath) && Date.now() < pidDeadline) {
         await Bun.sleep(25);
       }
-      expect(existsSync(pidPath)).toBe(true);
+      // Name what actually went wrong. A bare `false` here means "the pid file is
+      // missing" and nothing about whether PowerShell never started, the child died,
+      // or the runner was simply slow — which is most of the work in diagnosing it.
+      expect(
+        existsSync(pidPath),
+        `tray child never wrote ${pidPath} within ${PID_FILE_WAIT_MS}ms`,
+      ).toBe(true);
       childPid = Number(readFileSync(pidPath, "utf8"));
       expect(Number.isSafeInteger(childPid) && childPid > 0).toBe(true);
       expect(() => process.kill(childPid, 0)).not.toThrow();
@@ -293,7 +316,7 @@ describe("Windows tray packaging and command safety", () => {
       }
       rmSync(directory, { recursive: true, force: true });
     }
-  });
+  }, { timeout: TRAY_LAUNCH_TIMEOUT_MS });
 
   test("ships branded multi-size Windows tray icons", () => {
     const assets = join(import.meta.dir, "..", "src", "tray", "assets");