Skip to content

FIx typo in examples#1806

Merged
moratom merged 1 commit into
developfrom
bugfix/fix_typo
May 19, 2026
Merged

FIx typo in examples#1806
moratom merged 1 commit into
developfrom
bugfix/fix_typo

Conversation

@MaticTonin

@MaticTonin MaticTonin commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a build configuration issue with the RVC4 C++ example, enabling proper compilation.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 57676a87-1a9d-4656-9d14-032f3c96054d

📥 Commits

Reviewing files that changed from the base of the PR and between 387de9f and 58dd481.

📒 Files selected for processing (1)
  • examples/cpp/CMakeLists.txt
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: consistency
🔇 Additional comments (2)
examples/cpp/CMakeLists.txt (2)

152-152: LGTM!


152-152: ⚡ Quick win

No other instances of this CMake typo exist in the codebase.

Confirmed through comprehensive search across all CMakeLists.txt files—the typo pattern does not appear elsewhere.


📝 Walkthrough

Walkthrough

The pull request corrects a single typo in the CMake build configuration for C++ examples. The invalid CMake command addsubdirectory(RVC4) is fixed to the proper add_subdirectory(RVC4) function call, enabling the RVC4 example subdirectory to be correctly included in the build.

Changes

Build Configuration

Layer / File(s) Summary
CMake RVC4 subdirectory syntax correction
examples/cpp/CMakeLists.txt
The invalid addsubdirectory(RVC4) command is replaced with the correct add_subdirectory(RVC4) CMake function, allowing the RVC4 example to be properly added to the build system.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

A typo in CMake, a simple mistake,
addsubdirectory had the wrong shake.
One word, one dash, and now it's right,
RVC4 builds bright! ✨🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'FIx typo in examples' is directly related to the changeset, which fixes a misspelled function call (addsubdirectory → add_subdirectory) in examples/cpp/CMakeLists.txt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/fix_typo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moratom moratom merged commit 9f0d985 into develop May 19, 2026
46 of 48 checks passed
@moratom moratom deleted the bugfix/fix_typo branch May 19, 2026 22:34
@coderabbitai coderabbitai Bot mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants