VPP speed improvements#1820
Closed
MaticTonin wants to merge 2 commits into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve Neural Assisted Stereo throughput on RVC4. The VPP path was limiting
stereo.disparityoutput to roughly 30 FPS even when 60 FPS was requested. This change removes unnecessary VPP frame copies and reduces energy-map computation overhead, allowing NAS to reach ~60 FPS with the optimized FW.Dependencies & Potential Impact
No external dependency changes.
Deployment Plan
Roll out with the updated RVC4 firmware package.
Rollback: revert this PR or boot devices with the previous RVC4 FW package.
Monitoring: use the updated NAS profiling example or
BenchmarkIntelemetry to confirmstereo.disparityFPS, latency, CPU, memory, and temperature.Testing & Validation
Validated on RVC4 device
10.12.161.25.Old FW @ 60 FPS request:
29.83191.74 msNew FW @ 60 FPS:
59.98100.12 msResult:
2.01x47.8%Also validated new FW @ 30 FPS:
30.53115.45 msOld FW @ 30 FPS:
29.86212.31 msAdded C++ test:
[NeuralAssistedStereo] Requested 60 FPS reaches at least 50 FPSAI Usage
Assisted-by: OpenAI:Codex
Submitted code was reviewed by a human: YES
The author is taking the responsibility for the contribution: YES