Force use Windows-2022

[MaticTonin]

actions/runner-images#14017

Summary by CodeRabbit

• Chores
  • Updated continuous integration infrastructure to use standardized Windows build environments for improved consistency and reliability.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 997d0cba-96e0-48c5-9e31-293d33ed943d

📥 Commits

Reviewing files that changed from the base of the PR and between 3ebc943 and 5caa4e7.

📒 Files selected for processing (3)

• .github/workflows/main.workflow.yml
• .github/workflows/python-main.yml
• .github/workflows/test_child_windows.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)

• GitHub Check: build-windows-x86_64 (3.10, x64)
• GitHub Check: build-windows-x86_64 (3.9, x64)
• GitHub Check: build-linux-x86_64 (cp39-cp39)
• GitHub Check: build-linux-x86_64 (cp313-cp313)
• GitHub Check: build-linux-arm64 (cp312-cp312)
• GitHub Check: build-windows-x86_64 (3.13, x64)
• GitHub Check: pytest (ubuntu-latest)
• GitHub Check: build-linux-x86_64 (cp312-cp312)
• GitHub Check: build-linux-arm64 (cp310-cp310)
• GitHub Check: build-windows-x86_64 (3.11, x64)
• GitHub Check: build-windows-x86_64 (3.12, x64)
• GitHub Check: build-windows-x86_64 (3.14, x64)
• GitHub Check: build-linux-x86_64 (cp310-cp310)
• GitHub Check: build-linux-arm64 (cp314-cp314)
• GitHub Check: build-linux-x86_64 (cp314-cp314)
• GitHub Check: build-linux-x86_64 (cp311-cp311)
• GitHub Check: build-linux-arm64 (cp313-cp313)
• GitHub Check: build (windows-2022, 3.22.x)
• GitHub Check: integration (ubuntu-latest, Release, true, x64)
• GitHub Check: integration (windows-2022, Debug, true, x64)
• GitHub Check: integration (ubuntu-latest, Debug, true, x64)
• GitHub Check: integration (windows-2022, Release, true, x64)
• GitHub Check: build (windows-2022, 4.0.x)
• GitHub Check: build (ubuntu-latest, 4.0.x)
• GitHub Check: minimal-build
• GitHub Check: tidy
• GitHub Check: build (ubuntu-latest, 3.22.x)
• GitHub Check: style
• GitHub Check: run_windows_tests / build_windows_tests

🧰 Additional context used

🪛 actionlint (1.7.12)

.github/workflows/python-main.yml

[error] 143-143: the runner of "actions/cache@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🪛 zizmor (1.25.2)

.github/workflows/main.workflow.yml

[warning] 235-235: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)

.github/workflows/python-main.yml

[error] 143-143: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)

(unpinned-uses)

---

[error] 143-143: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): enables caching by default

(cache-poisoning)

🔇 Additional comments (3)

.github/workflows/main.workflow.yml (1)

142-142: LGTM!

Also applies to: 167-167, 183-183, 215-215, 231-231, 238-238

.github/workflows/python-main.yml (1)

130-130: LGTM!

Also applies to: 142-142, 148-152, 220-220, 241-241, 668-668

.github/workflows/test_child_windows.yml (1)

24-24: LGTM!

---

📝 Walkthrough

Walkthrough

Three GitHub Actions workflow files are updated to migrate from the generic windows-latest runner to the pinned windows-2022 runner. Build matrices, conditional step guards, cache keys, and artifact upload conditions are updated consistently across all three workflows.

Changes

Windows Runner Upgrade to windows-2022

Layer / File(s)	Summary
Main workflow build and integration jobs .github/workflows/main.workflow.yml	Build and integration job matrices updated to windows-2022; Windows-specific steps (dependency install, DLL path setup, artifact upload) now gated on matrix.os == 'windows-2022' conditions.
Python workflow build and cache jobs .github/workflows/python-main.yml	Build-windows-x86_64 and combine-windows-x86_64-wheels jobs changed to windows-2022 runner; pytest vcpkg cache split into explicit windows-2022 and non-windows-2022 branches with matching cache key updates.
Test child Windows job runner .github/workflows/test_child_windows.yml	Build_windows_tests job runner updated to windows-2022.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Windows 2022 awaits with cheer,
The runners pinned, no drift to fear,
Three workflows dance, in sync they go,
Conditions checked from high to low,
Cache keys renewed for speed so bright!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Force use Windows-2022' directly and specifically describes the main change: pinning CI workflows to use the Windows-2022 runner instead of windows-latest across three workflow files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/Windows_dependency_runner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[moratom]

We'll need to add support for VS 2026 later on, but that's fine to unblock