Parser, metrics and pre-processing consistency#17
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@klemen1999 just for bookkeeping this is the trace through that confirms that removing For an ONNX NNArchive:
|
Purpose
Note that this branches off
feat/abstract-enginesThis are a collection of fixes that were needed to account for:
dai.SegmentationMaskherestridesnow being passable and possibly non-defaultkeep_aspect_ratioshould match the default in LuxonisTrain (true) and some changes had to be made to normalization (don't skip if "identity normalization" is detected since this is not the same as LuxonisTrain identity normalization, skip normalization if we're ondepthaiengine otherwise it is performed twice)As a result, now we have metric consistency between LuxonisTrain .ckpt, ONNX NNArchive and FP16 RVC4 NNArchive for detection, instance segmentation, keypoints and semantic segmentation (tested with this depthai-nodes branch installed)
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO