[POC] Inject via marshaller and unmarshaller#16
Conversation
|
Oops, accidentally deleted the branch. Didn't mean to do that. This PR is still as intended. |
|
Got the benchmarks working too. I'm not sure how to run the Marshmallow test suite with this API, though. I'm sure I could figure something out. Still, how does this approach look? This seems easier to integrate, as it removes the "must uninstall Marshmallow" requirement. |
|
@rowillia Any thoughts here? |
|
@rowillia Ping! Does this seem like an interesting avenue to pursue? |
| install_requires=[ | ||
| 'attrs >= 17.1.0' | ||
| 'attrs >= 17.1.0', | ||
| 'marshmallow == 3.0.0b2', |
There was a problem hiding this comment.
By pinning it to == 3.0.0b2, users are forced to use this particular version of marshmallow. Can you change it to a less restrictive version bound?
There was a problem hiding this comment.
i'd need to make a small patch to upstream to work with the latest v3-line releases to factor out the marshaller again
There was a problem hiding this comment.
in general for pre-releases, there are no API-compatibility guarantees, so pinning a specific release is safest
There was a problem hiding this comment.
Ah I see, thanks! I'm interested in using toasted-marshmallow with the upcoming marshmallow 3 as well.
Have you considered forking since this repo seems to be unmaintained?
There was a problem hiding this comment.
i'd prefer not to do so. i don't understand the core code here well enough to really maintain it.
2 participants
This PR demonstrates injecting the JIT without adding any explicit hooks in Marshmallow. The tests in this test suite all pass, but I didn't patch the upstream vendored tests, as the configuration mechanism is now different.
This allows eliminating the custom Marshmallow fork.