Fix broken stubbed method expectation#1139
Merged
MaicolBen merged 1 commit intoApr 11, 2018
Merged
Conversation
- Update file to require correct Mocha lib for MiniTest (instead of Test::Unit). Using the wrong lib previously, meant that Mocha was never verifying the stubbed method, and the test passed (erroneously). - Update test to expect the correct method call for sign_in. Resolves lynndylanhurley#1137.
Merged
Collaborator
Author
|
@zachfeldman, @MaicolBen, @lynndylanhurley, @krzysiek1507 (or anyone else): Could a few people review this PR? It resolves the broken builds on master following the merge of #1134. |
MaicolBen
approved these changes
Apr 10, 2018
Collaborator
Author
|
As soon as I get a second approval, I will merge this! |
krzysiek1507
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update file to require correct Mocha lib for MiniTest (instead of
Test::Unit). Using the wrong lib previously, meant that Mocha was
never verifying the stubbed method, and the test passed
(erroneously).
Update test to expect the correct method call for sign_in.
Resolves #1137 (which was exposed by the merge of #1134).