Always ensure the newly created token expiry is not behind from exist…#1643
Closed
javaharut wants to merge 1 commit into
Closed
Always ensure the newly created token expiry is not behind from exist…#1643javaharut wants to merge 1 commit into
javaharut wants to merge 1 commit into
Conversation
Collaborator
|
can you add a test? |
javaharut
force-pushed
the
fix_user_signin_issue_on_device_limit
branch
from
e463e79 to
8aa3a3c
Compare
MaicolBen
reviewed
Jan 6, 2025
| token: token.token_hash, | ||
| expiry: token.expiry | ||
| token: token.token_hash, | ||
| expiry: [token.expiry, max_expiry + 1].max |
Author
There was a problem hiding this comment.
max_expiry is a timestamp and the expiry for the new token should be bigger than the current one and 1 is enough to achieve the goal
Collaborator
There was a problem hiding this comment.
sounds good, can you add a test?
Author
There was a problem hiding this comment.
@MaicolBen I tried to add but unfortunately cannot run test in my local. there is an instruction error in low level. How can I get help with this?
Collaborator
There was a problem hiding this comment.
That isn't enough details, anyway if you get an idea on how write it, share it here and I can make it work.
Collaborator
|
I believe #1657 fixed the same issue, let me know otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1618
It ensures that the new token's expiration date won't be erased during the creation process since in certain cases, the old tokens' expiration date may fall after the newly formed one.