Skip to content

Allow backup field authorization for login & password reset#538

Open
djsegal wants to merge 4 commits into
lynndylanhurley:masterfrom
djsegal:djsegal/backup
Open

Allow backup field authorization for login & password reset#538
djsegal wants to merge 4 commits into
lynndylanhurley:masterfrom
djsegal:djsegal/backup

Conversation

@djsegal

@djsegal djsegal commented Feb 14, 2016

Copy link
Copy Markdown
Contributor

Resolves: #509
Replaces: #510


Notes:

@booleanbetrayal

Copy link
Copy Markdown
Collaborator

Will try to take a look at this in the next couple of days @djsegal.

@lynndylanhurley / @nbrustein - could probably use some more eyes on this one!

@booleanbetrayal

Copy link
Copy Markdown
Collaborator

Afraid I've been swamped @djsegal. Will try to take a look at it ASAP unless @lynndylanhurley beats me to it.

@djsegal

djsegal commented Apr 21, 2016

Copy link
Copy Markdown
Contributor Author

@booleanbetrayal any word on this? I can look into doing a rebase if you think it's worth it.

@zachfeldman

Copy link
Copy Markdown
Contributor

Hi there @djsegal ,

In an effort to cleanup this project and prioritize a bit, we're marking pull requests that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this pull request. Obviously feel free to re-open it at any time if it's the right time or this was done in error! If you do, please rebase it with the latest master and explain why it's still needed.

We really appreciate your contribution, we're just trying to make this project manageable again to move it forward.

Hope all is well.

@djsegal

djsegal commented Oct 14, 2017

Copy link
Copy Markdown
Contributor Author

I think this is valuable enough to keep open

@lynndylanhurley

Copy link
Copy Markdown
Owner

@djsegal I apologize for the delay. Re-opening now, I'll look into this ASAP

@KelseyDH

KelseyDH commented Jan 18, 2018

Copy link
Copy Markdown
 @resource = q.find_by(provider: 'email')

Strongly recommend against any refactorings that presume or hardcore provider to be 'email.' I believe this forced coupling is an immense source of unneeded complexity within this gem that makes things very hard to change for anyone who is trying to configure this gem for use cases outside of email (like usernames or phone numbers).

@jerichoECKO

Copy link
Copy Markdown

Let's do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow backup field for login

7 participants