Skip to content

When debug specifier _and_ format_spec are present, use !s as the conversion default #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davepeck wants to merge 1 commit into from
Closed

When debug specifier _and_ format_spec are present, use !s as the conversion default #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Parser/action_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,9 +1467,10 @@ _get_interpolation_conversion(Parser *p, Token *debug, ResultTokenWithMetadata *
Py_UCS4 first = PyUnicode_READ_CHAR(conversion_expr->v.Name.id, 0);
return Py_SAFE_DOWNCAST(first, Py_UCS4, int);
}
else if (debug && !format) {
/* If no conversion is specified, use !r for debug expressions */
return (int)'r';
else if (debug) {
// If no conversion and no format are specified, use !r for debug expressions;
// otherwise, if a format is specified, use !s.
return format ? (int)'s' : (int)'r';
}
return -1;
}
Expand Down