Skip to content

style: revamp tag config panel#101

Merged
onkarj-47 merged 13 commits into
mainfrom
issue/100
Oct 28, 2025
Merged

style: revamp tag config panel#101
onkarj-47 merged 13 commits into
mainfrom
issue/100

Conversation

@onkarj-47

@onkarj-47 onkarj-47 commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

closing #100
Screenshot 2025-10-28 at 2 09 56 PM

<img width="347" height="627" alt="Screenshot 2025-10-28 at 3 36 15 PM" src="https://github.com/user-attachments/assets/3f894b38-c138-4c3e-b77d-b4a1d2277c08
Screenshot 2025-10-28 at 3 37 22 PM
" />

@anupsingh244 anupsingh244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check px to rem values, common color should be from theme, remove unwanted css comments and use shorthand properties to minimize css lines.

Comment thread src/pages/sidepanel/sections/TagConfig.tsx Outdated
Comment thread src/pages/sidepanel/components/BottomNavigation.tsx Outdated
Comment thread src/pages/sidepanel/sections/ProfileDetail.tsx Outdated
Comment thread src/pages/sidepanel/sections/TagConfig.tsx Outdated

@anupsingh244 anupsingh244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new comment, also check for failing test case.

Comment thread src/pages/sidepanel/components/BottomNavigation.tsx Outdated

@anupsingh244 anupsingh244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some css related test cases.

@onkarj-47

Copy link
Copy Markdown
Contributor Author

Remove some css related test cases.

resolved

@anupsingh244 anupsingh244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onkarj-47

Copy link
Copy Markdown
Contributor Author

Remove some css related test cases.

resolved

@onkarj-47
onkarj-47 merged commit 2dc856e into main Oct 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants