Lyt 133: Pinning domain sometimes throws an uncaught cross-origin SecurityError#134
Merged
Conversation
anupsingh244
requested review from
amey-contentstack,
asthamishra-cs,
ishaanB3006,
kaustubhjadhav-cs,
onkarj-47,
saisanthoshpentakota and
vedant-contentstack
as code owners
July 2, 2026 10:28
onkarj-47
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #133
This pull request introduces several improvements and bug fixes across the codebase, focusing on safer event serialization, more robust script injection, and better resource management. The most significant changes are grouped below.
Event Serialization & Error Handling:
safeClonemethod in bothtagLink.jsandtagLink.tsxto safely serialize event payloads, avoiding issues with circular references, non-plain objects, and unreadable properties. Event dispatching now uses this method, with error logging if serialization fails. [1] [2]dispatchEventin try/catch blocks when handlingconfigandentityevents, logging errors if reading or serializing data fails. [1] [2] [3] [4]Script Injection & Caching:
tagLink.js's URL, ensuring cache busting after extension updates. The build ID is injected at build time using Vite'sdefineoption. [1] [2]Resource & State Management:
UI Improvements:
TagActivityaccordion to use a stable key (item.ts) and enabled unmounting on exit for better React performance.Miscellaneous:
package.jsonto "Lytics Dev Tools" for consistency.