Skip to content

feat: import dispatch.yaml from mlab-ns and deploy it via cloudbuild#255

Open
robertodauria wants to merge 2 commits into
mainfrom
sandbox-roberto-dispatch
Open

feat: import dispatch.yaml from mlab-ns and deploy it via cloudbuild#255
robertodauria wants to merge 2 commits into
mainfrom
sandbox-roberto-dispatch

Conversation

@robertodauria

@robertodauria robertodauria commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

This change is Reviewable

@coveralls

coveralls commented Mar 4, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22676117205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.629%

Totals Coverage Status
Change from base Build 22631369720: 0.0%
Covered Lines: 2502
Relevant Lines: 3028

💛 - Coveralls

@bassosimone bassosimone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also deploy dispatch.yaml for mlab-sandbox and mlab-staging in the cloudbuild.yaml file, not just for mlab-ns. Otherwise we're not fully replicating what m-lab/mlab-ns's cloudbuild.yaml used to do. It deployed dispatch.yaml to all three projects (PROJECT_IN=mlab-sandbox,mlab-staging,mlab-ns - see https://github.com/m-lab/mlab-ns/blob/v2023.02.13/cloudbuild.yaml#L29).

@bassosimone bassosimone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems we are not ready yet to deploy this beyond staging. This merge request should be stalled until we have further operational clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants