3.0 #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: Build and deploy Diplodoc docs | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "docs/**" | ||
| - "docs/.yfm" | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - ".github/workflows/docs.yml" | ||
|
|
||
| pull_request: | ||
| paths: | ||
| - "docs/**" | ||
| - "docs/.yfm" | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - ".github/workflows/docs.yml" | ||
|
|
||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pages: write | ||
| id-token: write | ||
|
|
||
| concurrency: | ||
| group: github-pages-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build Diplodoc | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE=".github/workflows/docs.yml"
echo "== File: $FILE =="
[ -f "$FILE" ] || { echo "Missing $FILE"; exit 1; }
nl -ba "$FILE" | sed -n '1,140p'
echo
echo "== Extract all uses: lines =="
rg -n "^\s*uses:\s*" "$FILE" || true
echo
echo "== Check for SHA-pinned format (actions/*@<40-hex>) =="
python3 - <<'PY'
import re, pathlib
p = pathlib.Path(".github/workflows/docs.yml")
txt = p.read_text()
uses = []
for m in re.finditer(r'(?m)^\s*uses:\s*([^\s#]+)', txt):
uses.append((m.group(0).split(':',1)[0].strip(), m.group(1)))
pat = re.compile(r'@([0-9a-f]{40})$')
for full, ref in uses:
if '@' in ref and pat.search(ref):
print("SHA pinned:", ref)
else:
print("NOT SHA pinned:", ref)
PYRepository: m-xim/aiogram-webhook Length of output: 165 🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE=".github/workflows/docs.yml"
echo "== File exists? $FILE =="
[ -f "$FILE" ] && echo "YES" || { echo "NO"; exit 1; }
echo
echo "== Show lines 1-140 (numbered) =="
cat -n "$FILE" | sed -n '1,140p'
echo
echo "== uses: entries =="
rg -n "^[[:space:]]*uses:[[:space:]]*" "$FILE" || true
echo
echo "== SHA-pinning check for actions/*@<40-hex> =="
python3 - <<'PY'
import re, pathlib
p = pathlib.Path(".github/workflows/docs.yml")
txt = p.read_text()
uses = []
for m in re.finditer(r'(?m)^\s*uses:\s*([^\s#]+)', txt):
uses.append(m.group(1).strip())
sha_pat = re.compile(r'@([0-9a-f]{40})$')
for ref in uses:
m = sha_pat.search(ref)
if m:
print(f"SHA pinned: {ref}")
else:
print(f"NOT SHA pinned: {ref}")
PY
echo
echo "== Show referenced lines (40,45,53,69,90) =="
for L in 40 45 53 69 90; do
echo "--- $L ---"
sed -n "${L}p" "$FILE" | cat -n
doneRepository: m-xim/aiogram-webhook Length of output: 3577 Pin GitHub Actions by commit SHA in
🧰 Tools🪛 zizmor (1.25.2)[error] 40-40: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| with: | ||
| fetch-depth: 0 | ||
|
Comment on lines
+39
to
+42
There was a problem hiding this comment. Disable persisted checkout credentials in the build job. Use Suggested fix - name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0
+ persist-credentials: false🧰 Tools🪛 zizmor (1.25.2)[warning] 39-42: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 40-40: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - name: Install project dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Configure GitHub Pages | ||
| uses: actions/configure-pages@v5 | ||
|
|
||
| - name: Build docs | ||
| env: | ||
| GITHUB_OWNER: ${{ github.repository_owner }} | ||
| GITHUB_REPO: ${{ github.event.repository.name }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_BASE_URL: https://api.github.com | ||
| VCS_CONNECTOR_TYPE: github | ||
| VCS_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: npm run build | ||
|
|
||
| - name: Disable Jekyll | ||
| run: touch ./docs-html/.nojekyll | ||
|
|
||
| - name: Upload GitHub Pages artifact | ||
| uses: actions/upload-pages-artifact@v3 | ||
| with: | ||
| path: "./docs-html" | ||
|
|
||
| deploy: | ||
| name: Deploy to GitHub Pages | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' | ||
|
|
||
| permissions: | ||
| pages: write | ||
| id-token: write | ||
|
|
||
| environment: | ||
| name: github-pages | ||
| url: ${{ steps.deployment.outputs.page_url }} | ||
|
|
||
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 | ||
|
m-xim marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,54 +1,54 @@ | ||||||||||||||||||||||||
| name: Release & Publish | ||||||||||||||||||||||||
|
coderabbitai[bot] marked this conversation as resolved.
|
||||||||||||||||||||||||
| on: workflow_dispatch | ||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||
| release: | ||||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||||
| concurrency: | ||||||||||||||||||||||||
| group: ${{ github.workflow }}-release-${{ github.ref_name }} | ||||||||||||||||||||||||
| cancel-in-progress: true | ||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||
| id-token: write | ||||||||||||||||||||||||
| contents: write | ||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||
| - name: 🛎️ Checkout repository | ||||||||||||||||||||||||
| uses: actions/checkout@v6 | ||||||||||||||||||||||||
|
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE=".github/workflows/release.yml"
echo "== File = $FILE =="
if [ ! -f "$FILE" ]; then
echo "Missing: $FILE"
exit 1
fi
nl -ba "$FILE" | sed -n '1,200p'
echo
echo "== uses: entries =="
rg -n --no-heading "uses:\s*[^@]+@(.+)$" "$FILE" || true
echo
echo "== uses: entries with non-SHA refs =="
# Heuristic: commit SHAs are typically 40 hex chars (or shorter if tags), so flag refs that aren't 40-hex.
rg -n --no-heading "uses:\s*[^@]+@([0-9a-fA-F]{40})\b" "$FILE" || true
# Print all uses again with ref values
rg -n --no-heading "uses:\s*([^@]+)@(.+)$" "$FILE" | sed -E 's/uses:[[:space:]]*([^@]+)@(.+)/\1@\2/' || trueRepository: m-xim/aiogram-webhook Length of output: 170 🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE=".github/workflows/release.yml"
echo "== Check file exists =="
ls -la "$FILE" || { echo "Missing: $FILE"; exit 1; }
echo
echo "== File head (with line numbers) =="
cat -n "$FILE" | sed -n '1,200p'
echo
echo "== All uses: entries =="
rg -n --no-heading '^\s*uses:\s*[^@]+@(.+)$' "$FILE" || true
echo
echo "== uses: entries with refs that look like commit SHAs (40 hex) =="
rg -n --no-heading '^\s*uses:\s*[^@]+@[0-9a-fA-F]{40}\b' "$FILE" || trueRepository: m-xim/aiogram-webhook Length of output: 2530 Pin workflow actions to immutable SHAs. The workflow uses version tags (not commit SHAs) for multiple actions—e.g., 🧰 Tools🪛 zizmor (1.25.2)[error] 18-18: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||
| ref: ${{ github.ref_name }} | ||||||||||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||||||||||
|
Comment on lines
+17
to
+21
There was a problem hiding this comment. Harden checkout by disabling credential persistence. Set Suggested fix - name: 🛎️ Checkout repository
uses: actions/checkout@v6
with:
ref: ${{ github.ref_name }}
fetch-depth: 0
+ persist-credentials: false📝 Committable suggestion
Suggested change
🧰 Tools🪛 zizmor (1.25.2)[warning] 17-21: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 18-18: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||||||||||||||
| - name: 🏷️ Semantic Version Release | ||||||||||||||||||||||||
| id: release | ||||||||||||||||||||||||
| uses: python-semantic-release/python-semantic-release@v10.5.3 | ||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||||||||||||||||||||
| git_committer_name: "github-actions" | ||||||||||||||||||||||||
| git_committer_email: "actions@users.noreply.github.com" | ||||||||||||||||||||||||
| - name: 🐍 Setup uv & venv | ||||||||||||||||||||||||
| if: steps.release.outputs.released == 'true' | ||||||||||||||||||||||||
| uses: astral-sh/setup-uv@v8.1.0 | ||||||||||||||||||||||||
| - name: 📦 Update uv.lock | ||||||||||||||||||||||||
| if: steps.release.outputs.released == 'true' | ||||||||||||||||||||||||
| run: uv lock | ||||||||||||||||||||||||
| - name: 🏗️ Build package (sdist & wheel) | ||||||||||||||||||||||||
| if: steps.release.outputs.released == 'true' | ||||||||||||||||||||||||
| run: uv build --no-sources | ||||||||||||||||||||||||
| - name: 🚀 Publish | Upload to GitHub Release Assets | ||||||||||||||||||||||||
| if: steps.release.outputs.released == 'true' | ||||||||||||||||||||||||
| uses: python-semantic-release/publish-action@v10.5.3 | ||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||||||||||||||||||||
| tag: ${{ steps.release.outputs.tag }} | ||||||||||||||||||||||||
| - name: 🐍 Publish to PyPI | ||||||||||||||||||||||||
| if: steps.release.outputs.released == 'true' | ||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||
| UV_PUBLISH_TOKEN: ${{ secrets.PYPI_TOKEN }} | ||||||||||||||||||||||||
| run: uv publish | ||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,47 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| pull_request: | ||
| branches: [main, develop] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| lint-and-test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Install uv and set the python version | ||
| uses: astral-sh/setup-uv@v8.1.0 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install the project | ||
| run: uv sync --all-extras | ||
|
|
||
| - name: Run Ruff | ||
| run: uv run ruff check --output-format=github . | ||
|
|
||
| - name: Run Ty (type checker) | ||
| run: uv run ty check --output-format=github . | ||
|
|
||
| - name: Run pytest | ||
| run: uv run pytest --cov --cov-branch --cov-report=xml | ||
|
|
||
| - name: Upload results to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduce workflow-level token scope to least privilege.
pages: writeandid-token: writeat workflow scope are broader than necessary; onlydeployneeds them.Suggested fix
🧰 Tools
🪛 zizmor (1.25.2)
[error] 26-26: overly broad permissions (excessive-permissions): pages: write is overly broad at the workflow level
(excessive-permissions)
[error] 27-27: overly broad permissions (excessive-permissions): id-token: write is overly broad at the workflow level
(excessive-permissions)
🤖 Prompt for AI Agents
Source: Linters/SAST tools