fix: resolve npm install peer dependency conflict#7
Merged
Conversation
The plugin requires prettier-plugin-solidity@^1.0.0 but the project uses v2.x, causing npm install to fail. Prettier is already run separately via lint-staged, so this plugin is redundant.
- brace-expansion: 2.0.1 → 2.0.2 (ReDoS fix) - js-yaml: 4.1.0 → 4.1.1 (prototype pollution fix)
There was a problem hiding this comment.
Pull request overview
This PR resolves npm installation issues by removing the solhint-plugin-prettier package which has a peer dependency conflict with the project's prettier-plugin-solidity version (requires v1.x but project uses v2.x). The removal is safe since prettier formatting is already enforced through lint-staged configuration.
Changes:
- Removed
solhint-plugin-prettierpackage dependency - Removed prettier plugin configuration from
.solhint.json
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed solhint-plugin-prettier dependency to resolve peer dependency conflict |
| .solhint.json | Removed prettier plugin and rule references from solhint configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solhint-plugin-prettierwhich requiresprettier-plugin-solidity@^1.0.0but the project uses v2.x, causingnpm installto failbrace-expansion,js-yaml)Prettier enforcement is already handled via lint-staged, so the plugin was redundant.