Skip to content

Add ADFS certificatemixed endpoint and MEX metadata#1

Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
feature/adfs-certificatemixed-and-mex-2833209677669845791
Draft

Add ADFS certificatemixed endpoint and MEX metadata#1
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
feature/adfs-certificatemixed-and-mex-2833209677669845791

Conversation

@google-labs-jules
Copy link
Copy Markdown

Implemented certificatemixed endpoint and updated metadata generation to include WS-Trust endpoints.

Changes:
- Modified `src/IdP/MetadataBuilder.php` to optionally include `mex`, `certificatemixed`, and `usernamemixed` endpoints in the `SecurityTokenService` descriptor.
- Added `certificatemixed` method to `src/Controller/Adfs.php` to handle requests to the new endpoint.
- Added `receiveCertificateAuthnRequest` to `src/IdP/ADFS.php`. This method parses the SOAP request, extracts the `BinarySecurityToken` (X.509 certificate), verifies the SOAP signature, validates the certificate against a configured list of CAs, and authenticates the user based on the certificate's Subject/SAN.
- Registered the new route `adfs-wstrust-certificatemixed` in `routing/routes/routes.yml`.

PR created automatically by Jules for task 2833209677669845791 started by @m0ark

    Integrates the certificatemixed endpoint for certificate-based authentication
    using WS-Trust. The endpoint verifies the SOAP signature and validates the
    client certificate against a configured list of CAs.

    Also updates the MetadataBuilder to include the MEX (Metadata Exchange),
    certificatemixed, and usernamemixed endpoints in the generated SAML metadata
    configuration.

    New configuration options in adfs-idp-hosted metadata:
    - certificate_authorities: array of paths to trusted CA certificates.
    - adfs.mex_in_metadata: boolean to include MEX endpoint.
    - adfs.certificatemixed_in_metadata: boolean to include certificatemixed endpoint.
    - adfs.usernamemixed_in_metadata: boolean to include usernamemixed endpoint.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants