[M3Aggregator ] Fix server address handling if m3msg config stanza present#2568
Open
yyin-sc wants to merge 1 commit intom3db:masterfrom
Open
[M3Aggregator ] Fix server address handling if m3msg config stanza present#2568yyin-sc wants to merge 1 commit intom3db:masterfrom
yyin-sc wants to merge 1 commit intom3db:masterfrom
Conversation
|
|
yyin-sc
changed the title
yyin-sc
force-pushed
the
evan-fix-aggregator
branch
from
66cfef7 to
6c486d3
Compare
robskillington
force-pushed
the
master
branch
from
834e25e to
99f874f
Compare
robskillington
force-pushed
the
master
branch
from
e130b7e to
3cf877e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2568 +/- ##
======================================
Coverage 71.7% 71.7%
======================================
Files 1081 1081
Lines 95720 95723 +3
======================================
+ Hits 68678 68688 +10
+ Misses 22423 22420 -3
+ Partials 4619 4615 -4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #
Don't have an open issue right now, I can go back creating an issue if needed, just want to quickly show my proposed changes for the issue.
The issues was that m3aggregator failed to comes up due to below errors when we trying to update the aggregator server from rawTcp to m3msg.
{"level":"fatal","ts":1597258192.1929145,"msg":"error creating aggregator options","error":"error parsing server address : missing port in address"}
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: