WIP [dbnode] Concurrent stream metadata in single shard for higher peer stream throughput#2597
WIP [dbnode] Concurrent stream metadata in single shard for higher peer stream throughput#2597robskillington wants to merge 19 commits intomasterfrom
Conversation
| if err != nil { | ||
| errorsLock.Lock() | ||
| errors = errors.Add(err) | ||
| errorsLock.Unlock() |
There was a problem hiding this comment.
we should return error here, no?
There was a problem hiding this comment.
We check this at the end, can't return error here unfortunately since it's an async goroutine.
834e25e to
99f874f
Compare
e130b7e to
3cf877e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2597 +/- ##
=========================================
- Coverage 71.5% 63.7% -7.8%
=========================================
Files 1083 816 -267
Lines 96391 78674 -17717
=========================================
- Hits 68949 50185 -18764
- Misses 22814 24606 +1792
+ Partials 4628 3883 -745
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What this PR does / why we need it:
Work in progress.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: