Skip to content

WIP [dbnode] Concurrent stream metadata in single shard for higher peer stream throughput#2597

Open
robskillington wants to merge 19 commits intomasterfrom
r/parallel-stream-metadata-per-shard
Open

WIP [dbnode] Concurrent stream metadata in single shard for higher peer stream throughput#2597
robskillington wants to merge 19 commits intomasterfrom
r/parallel-stream-metadata-per-shard

Conversation

@robskillington
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Work in progress.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

if err != nil {
errorsLock.Lock()
errors = errors.Add(err)
errorsLock.Unlock()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should return error here, no?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We check this at the end, can't return error here unfortunately since it's an async goroutine.

Base automatically changed from r/parallel-flush-shards-peer-stream to master October 14, 2020 22:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2023

Codecov Report

❌ Patch coverage is 69.42675% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.7%. Comparing base (225a0c4) to head (25b6a8c).
⚠️ Report is 1302 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (225a0c4) and HEAD (25b6a8c). Click for more details.

HEAD has 60 uploads less than BASE
Flag BASE (225a0c4) HEAD (25b6a8c)
collector 16 6
aggregator 15 6
m3em 12 6
cluster 13 6
msg 5 4
dbnode 13 6
query 8 2
m3ninx 7 2
m3nsch 7 2
x 6 2
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2597      +/-   ##
=========================================
- Coverage    71.5%   63.7%    -7.8%     
=========================================
  Files        1083     816     -267     
  Lines       96391   78674   -17717     
=========================================
- Hits        68949   50185   -18764     
- Misses      22814   24606    +1792     
+ Partials     4628    3883     -745     
Flag Coverage Δ
aggregator 63.5% <ø> (-12.5%) ⬇️
cluster 84.6% <ø> (-0.5%) ⬇️
collector 62.3% <ø> (-20.6%) ⬇️
dbnode 67.2% <69.8%> (-12.2%) ⬇️
m3em 63.7% <ø> (-10.7%) ⬇️
m3ninx 65.4% <ø> (-6.9%) ⬇️
m3nsch 78.0% <ø> (+26.8%) ⬆️
metrics 17.2% <ø> (ø)
msg 75.3% <ø> (ø)
query 68.4% <20.0%> (+1.5%) ⬆️
x 82.3% <75.0%> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225a0c4...25b6a8c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants