[dbnode] Update WriteShardsInitializing comment#3205
Open
ChrisChinchilla wants to merge 2 commits intomasterfrom
Open
[dbnode] Update WriteShardsInitializing comment#3205ChrisChinchilla wants to merge 2 commits intomasterfrom
ChrisChinchilla wants to merge 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
+ Coverage 57.5% 72.3% +14.8%
==========================================
Files 551 1094 +543
Lines 64031 100962 +36931
==========================================
+ Hits 36824 73032 +36208
+ Misses 24012 22865 -1147
- Partials 3195 5065 +1870
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Chris Chinchilla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment for WriteShardsInitializing was a duplicate of the comment for ShardsLeavingCountTowardsConsistency, this PR adds a relevant comment.