Skip to content

[dbnode] Update WriteShardsInitializing comment#3205

Open
ChrisChinchilla wants to merge 2 commits intomasterfrom
ChrisChinchilla-patch-4
Open

[dbnode] Update WriteShardsInitializing comment#3205
ChrisChinchilla wants to merge 2 commits intomasterfrom
ChrisChinchilla-patch-4

Conversation

@ChrisChinchilla
Copy link
Copy Markdown
Contributor

The comment for WriteShardsInitializing was a duplicate of the comment for ShardsLeavingCountTowardsConsistency, this PR adds a relevant comment.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2021

Codecov Report

Merging #3205 (ee6aa22) into master (0ab7b10) will increase coverage by 14.8%.
The diff coverage is n/a.

❗ Current head ee6aa22 differs from pull request most recent head a42eac0. Consider uploading reports for the commit a42eac0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
+ Coverage    57.5%    72.3%   +14.8%     
==========================================
  Files         551     1094     +543     
  Lines       64031   100962   +36931     
==========================================
+ Hits        36824    73032   +36208     
+ Misses      24012    22865    -1147     
- Partials     3195     5065    +1870     
Flag Coverage Δ
aggregator 75.8% <ø> (+18.6%) ⬆️
cluster 84.9% <ø> (∅)
collector 84.3% <ø> (+25.8%) ⬆️
dbnode 78.7% <ø> (+16.3%) ⬆️
m3em 74.4% <ø> (+27.9%) ⬆️
m3ninx 73.3% <ø> (?)
metrics 20.0% <ø> (+0.2%) ⬆️
msg 74.2% <ø> (-0.2%) ⬇️
query 67.2% <ø> (?)
x 80.1% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab7b10...a42eac0. Read the comment docs.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Chinchilla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants