move gcs and s3 deps to extras#504
Open
hirosassa wants to merge 3 commits intom3dev:masterfrom
Open
Conversation
kitagry
approved these changes
Apr 26, 2026
Comment on lines
-15
to
+14
| def get_s3_client(self) -> luigi.contrib.s3.S3Client: | ||
| def get_s3_client(self): |
Member
There was a problem hiding this comment.
Could you add something like the following? I think it would be better to add type annotations.
if TYPE_CHECKING:
import luigi.contrib.s3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
pip install gokart previously bundled cloud storage libraries even when unused, increasing package size unnecessarily.
By making these optional, users who don't need S3/GCS can reduce dependencies by up to ~109 MB.
Dependency size impact
Compared to
gokart[all](~110 MB of extras dependencies):[all]pip install gokartpip install gokart[s3]pip install gokart[gcs]pip install gokart[all]Breaking Changes
S3/GCS functionality is no longer available with a bare pip install gokart. Users must opt in:
Changes