Add nfcaEmulationTransmit and remove redundant _u.update in emulation

Author: GOB52

src/nfc/layer/a/emulation_layer_a_ST25R3916.cpp

@@ -186,9 +186,9 @@ bool ListenerST25R3916ForA::stop_emulation()
            _u.writeModeDefinition(0x00);
 }
 
-bool ListenerST25R3916ForA::transmit(const uint8_t* tx, const uint16_t tx_len, const uint32_t timeout_ms)
+bool ListenerST25R3916ForA::transmit(const uint8_t* tx, const uint16_t tx_len, const uint32_t /*timeout_ms*/)
 {
-    return _u.nfcaTransmit(tx, tx_len, timeout_ms);
+    return _u.nfcaEmulationTransmit(tx, tx_len);
 }
 
 // ------------------------------------------------------------
@@ -273,7 +273,6 @@ EmulationLayerA::State ListenerST25R3916ForA::goto_idle()
 
     _wakeup = false;
 
-    _u.update();
     return update_idle();
     //    return EmulationLayerA::State::Idle;
 }
@@ -292,7 +291,6 @@ EmulationLayerA::State ListenerST25R3916ForA::goto_ready()
     _u.clear_bit_register8(REG_OPERATION_CONTROL, wu);  // Disable wakeup mode
     _u.writeModeDefinition(mode_listen_nfc_a);          // Disable bitrate detection and collision
 
-    _u.update();
     return update_ready();
     //    return EmulationLayerA::State::Ready;
 }
@@ -305,7 +303,6 @@ EmulationLayerA::State ListenerST25R3916ForA::goto_active()
 
     _u.enable_interrupts(I_rxe32);
 
-    _u.update();
     return update_active();
     //    return EmulationLayerA::State::Active;
 }
@@ -326,7 +323,6 @@ EmulationLayerA::State ListenerST25R3916ForA::goto_halt()
         return goto_off();
     }
 
-    _u.update();
     return update_halt();
     //    return EmulationLayerA::State::Halt;
 }

src/unit/unit_ST25R3916.hpp

@@ -1749,6 +1749,8 @@ class UnitST25R3916 : public Component {
     uint32_t nfcaTransceive(uint8_t* rx, uint16_t& rx_len, const uint8_t* tx, const uint16_t tx_len,
                             const uint32_t timeout_ms);
     bool nfcaTransmit(const uint8_t* tx, const uint16_t tx_len, const uint32_t timeout_ms);
+    //! @brief Transmit in emulation (PICC) mode with minimal I2C overhead
+    bool nfcaEmulationTransmit(const uint8_t* tx, const uint16_t tx_len);
     bool nfcaReceive(uint8_t* rx, uint16_t& rx_len, const uint32_t timeout_ms);
 
     /*!

src/unit/unit_ST25R3916_nfca.cpp

@@ -205,6 +205,16 @@ bool UnitST25R3916::nfcaTransmit(const uint8_t* tx, const uint16_t tx_len, const
     return true;
 }
 
+bool UnitST25R3916::nfcaEmulationTransmit(const uint8_t* tx, const uint16_t tx_len)
+{
+    if (!tx || !tx_len) {
+        return false;
+    }
+    return writeDirectCommand(CMD_CLEAR_FIFO) &&  //
+           writeFIFO(tx, tx_len) &&               //
+           writeNumberOfTransmittedBytes(tx_len, 0) && writeDirectCommand(CMD_TRANSMIT_WITH_CRC);
+}
+
 bool UnitST25R3916::nfcaReceive(uint8_t* rx, uint16_t& rx_len, const uint32_t timeout_ms)
 {
     CHECK_MODE();